You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
setintersection_update, difference_update, symmetric_difference_update should check self is equal to given arg #3881
They are also relevant to inplace operations( iand, isub, ixor ).
CPython checks whether given argument and selfobject are equal and then returns.
intersection_update : If self == arg, returns self.copy()
difference_update : If self == arg, returns self.clear(); Ok(())
symmetric_difference_update : If self == arg, returns self.clear(); Ok(())
At the current implementation, they get a parameter as SetIterable which is converted from PyObjectRef before entering each method.
For checking self == arg, we should convert it after checking.
Activity
kth496 commentedon Jul 15, 2022
@youknowone Could you assign me to this issue? 😀
DimitrisJim commentedon Nov 7, 2022
Bump, hey @kth496, any chance you have time to finish this up?