Repository navigation
Fix collection(s) repr to correctly handle subclasses #3217
Description
In CPython:
>>> from collections import deque
>>> class MyDeque(deque): pass
>>> MyDeque()
'MyDeque([])'While in RustPython:
>>>>> from collections import deque
>>>>> class MyDeque(deque): pass
>>>>> MyDeque()
deque([])This needs to be applied for set, frozenset and bytearray too.
Prior similar work: #3137
Activity
[-]Fix deque.__repr__ to correctly handle subclasses[/-][+]Fix collection(s) repr to correctly handle subclasses[/+]Snowapril commentedon Oct 4, 2021
currently, rustpython's
repris hardcoded with its name. maybe fix it withnamemethod inpytypecan be work.fix: __repr__ use collection subclass name
muscar commentedon Oct 4, 2021
I think this addresses the issue: https://github.com/RustPython/RustPython/pull/3219/files.
DimitrisJim commentedon Oct 4, 2021
Please request to work on issues and then someone can assign you (or, at the very least, leave a comment). #3218 and #3219 are in conflict. @muscar if possible, alter your PR to only fix the classes other than deque. This way both PRs can be merged!
Please do request things though, it makes it easier for everyone involved 😄
youknowone commentedon Oct 4, 2021
well, claims will be respected but generally it is not necessary. (at least, we were not using that workflow before.)
If there is no claim, first PR will be preferred to be merged without special reasons.
DimitrisJim commentedon Oct 4, 2021
Oh sure, I'm not saying otherwise. Requesting things just makes it easier and doesn't result in one of the PRs being closed (and possibly disheartening new contributors).
muscar commentedon Oct 5, 2021
Fair enough :) Will as on any future ones.
fix: __repr__ use collection subclass name
fix: __repr__ use collection subclass name