Repository navigation
dict_keys, dict_values, and dict_items are missing several methods #2898
Description
Feature
CPython:
>>> dir(dict().keys())
['__and__', '__class__', '__contains__', '__delattr__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__iter__', '__le__', '__len__', '__lt__', '__ne__', '__new__', '__or__', '__rand__', '__reduce__', '__reduce_ex__', '__repr__', '__reversed__', '__ror__', '__rsub__', '__rxor__', '__setattr__', '__sizeof__', '__str__', '__sub__', '__subclasshook__', '__xor__', 'isdisjoint']RustPython:
>>>>> dir(dict().keys())
['__class__', '__delattr__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__iter__', '__le__', '__len__', '__lt__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__reversed__', '__setattr__', '__str__', '__subclasshook__']Diff:
'__contains__''__and__''__rxor__''isdisjoint''__or__''__rand__''__ror__''__xor__''__rsub__''__sub__''__sizeof__'
The same is for dict_values and dict_items
Activity
[-]`dict_keys` is missing several methods[/-][+]`dict_keys`, `dict_values`, and `dict_items` are missing several methods[/+]DimitrisJim commentedon Aug 16, 2021
Yup, I don't think a macro should be used to generate the types as is currently done. For their respective iterators, the macro seems like a good idea, for the types, not that much.
DimitrisJim commentedon Aug 16, 2021
Additionally, though
item in viewcurrently works (falling back to iterating), it can beO(1)forkeysanditemsviews by keying the dict ref they hold.youknowone commentedon Nov 28, 2021
is this done? can we list up what's done and left?
rvsampson94 commentedon Nov 30, 2021
I think sizeof is the last one that needs to be merged. After that it should be done.
John15321 commentedon May 27, 2022
Hey if its done you guys should close the issue :)
youknowone commentedon May 27, 2022
@John15321 thank you!