You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd also submit a PR @sobolevn. The devguide states this at some point. You might want to check that it indeed isn't covered by running gcov but that sounds like overkill in this case.
Activity
sobolevn commentedon Aug 10, 2021
The fix is on its way 🚂
Fixes that `id()` of `tuple` was changing on `* 1`, refs RustPython#2840
DimitrisJim commentedon Aug 10, 2021
Note: similar issue is present for the other immutables that can be multiplied, (
strandbytes). Pick those up too if you're up for it.[-]`id(a) != id(a * 1)` for `tuple` type[/-][+]`id(a) != id(a * 1)` for `tuple`, str and bytes [/+]sobolevn commentedon Aug 11, 2021
Yeap, will add
strandbytessupport in a moment 💯`id()` for `bytes` stays the same after `* 1`, refs RustPython#2840
sobolevn commentedon Aug 11, 2021
Related bug report about missing
strandbytestests: https://bugs.python.org/issue44891`id()` for `str` stays the same after `* 1`, refs RustPython#2840
DimitrisJim commentedon Aug 12, 2021
I'd also submit a PR @sobolevn. The devguide states this at some point. You might want to check that it indeed isn't covered by running gcov but that sounds like overkill in this case.