Repository navigation
Add missing deque methods #2812
Description
Current basic methods are not implemented on deque:
-
collections.dequedoesn't have__add__method #2835 -
collections.dequedoesn't have a__bool__method. #2837 -
collections.dequedoesn't have__iadd__method. #2838 -
collections.dequedoesn't have__imul__method. #2839 -
collections.dequedoes not have__rmul__method #2834 -
collections.dequedoesn't have__reversed__method #2836
Activity
OhBonsai commentedon Aug 9, 2021
Hi, I would like to do some work on this. Could you @DimitrisJim get me up to speed quickly on this? :)
DimitrisJim commentedon Aug 9, 2021
Of course @OhBonsai. You can start by taking a look at the other methods implemented for
deque, these will give you an idea on how to manipulate the underlyingVecDequeto get the behavior needed. You can drop in at gitter and ask about anything if you get stuck at some point.DimitrisJim commentedon Aug 10, 2021
Hey @OhBonsai , pick one of the issues linked and I can assign it to you and guide you through anything you need over there.
whgusdn321 commentedon Aug 11, 2021
@OhBonsai Hello I'm interested in this issue also. If you don't mind, I would like to contribute some of them. would it be possible? and if it's okay, what are you going to implement among these? I'll implement the ones you don't pick.
( collections.deque doesn't have add method #2835
collections.deque doesn't have a bool method. #2837
collections.deque doesn't have iadd method. #2838
collections.deque doesn't have imul method. #2839
collections.deque does not have rmul method #2834
collections.deque doesn't have reversed method #2836)
OhBonsai commentedon Aug 11, 2021
@whgusdn321 Wows, It's seem like i can ride your coattails 😄 .
I think i could choose
bool. It looks simpler~. BTW add/iadd/imul/rmul have been assigned~. Just reversed leaved 😢youknowone commentedon Aug 11, 2021
general tip:
listandtuplehave similar implementations for similar magic methods.hk1997 commentedon Sep 4, 2021
Hi,
Is it still open?
DimitrisJim commentedon Sep 5, 2021
Ah, I'm afraid not, the last part of this issue is being worked on by someone atm.
I'll try and see if I can find any other easy issues soon though, so, be on the look-out for them.
DimitrisJim commentedon Sep 11, 2021
@hk1997 see #3039 for a couple more good first issues you could try and take-up.