Iterable for PyGenericAlias

youknowone · youknowone · commit f016716c3147 · 2025-07-01T02:37:13.000+09:00
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
@@ -680,8 +680,6 @@ def test_typevartuple(self):
         class A(Generic[Unpack[Ts]]): ...
         Alias = Optional[Unpack[Ts]]
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_typevartuple_specialization(self):
         T = TypeVar("T")
         Ts = TypeVarTuple('Ts', default=Unpack[Tuple[str, int]])
@@ -1049,8 +1047,6 @@ class C(Generic[T1, T2]): pass
                             eval(expected_str)
                         )
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_three_parameters(self):
         T1 = TypeVar('T1')
         T2 = TypeVar('T2')
diff --git a/vm/src/builtins/genericalias.rs b/vm/src/builtins/genericalias.rs
@@ -12,8 +12,8 @@ use crate::{
     function::{FuncArgs, PyComparisonValue},
     protocol::{PyMappingMethods, PyNumberMethods},
     types::{
-        AsMapping, AsNumber, Callable, Comparable, Constructor, GetAttr, Hashable, PyComparisonOp,
-        Representable,
+        AsMapping, AsNumber, Callable, Comparable, Constructor, GetAttr, Hashable, Iterable,
+        PyComparisonOp, Representable,
     },
 };
 use std::fmt;
@@ -78,6 +78,7 @@ impl Constructor for PyGenericAlias {
         Constructor,
         GetAttr,
         Hashable,
+        Iterable,
         Representable
     ),
     flags(BASETYPE)
@@ -490,6 +491,13 @@ impl Representable for PyGenericAlias {
     }
 }
 
+impl Iterable for PyGenericAlias {
+    fn iter(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyResult {
+        // Return an iterator over the args tuple
+        Ok(zelf.args.clone().to_pyobject(vm).get_iter(vm)?.into())
+    }
+}
+
 pub fn init(context: &Context) {
     let generic_alias_type = &context.types.generic_alias_type;
     PyGenericAlias::extend_class(context, generic_alias_type);
