Enfore cloned_instead_of_copied

ShaharNaveh · ShaharNaveh · commit d2f0c6fb940b · 2026-05-02T15:18:09.000+03:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -254,7 +254,7 @@ suspicious = { level = "warn", priority = -2 }
 perf = { level = "warn", priority = -2 }
 style = { level = "warn", priority = -2 }
 complexity = { level = "warn", priority = -2 }
-# pedantic = { level = "warn", priority = -2 }
+# pedantic = { level = "warn", priority = -2 } # TODO: Enable this
 
 missing_errors_doc = "allow" # Too many errors. No auto-fix available
 missing_panics_doc = "allow" # Too many errors. No auto-fix available
@@ -263,8 +263,6 @@ if_not_else = "allow" # Not always more readable
 single_match_else = "allow"
 similar_names = "allow"
 
-must_use_candidate = "warn"
-
 alloc_instead_of_core = "warn"
 std_instead_of_alloc = "warn"
 std_instead_of_core = "warn"
@@ -277,3 +275,7 @@ unused_peekable = "warn"
 manual_is_variant_and = "warn"
 or_fun_call = "warn"
 unnested_or_patterns = "warn"
+
+# pendantic lints to enforce gradually
+cloned_instead_of_copied = "warn"
+must_use_candidate = "warn"
diff --git a/crates/common/src/cformat.rs b/crates/common/src/cformat.rs
@@ -834,7 +834,7 @@ pub type CFormatBytes = CFormatStrOrBytes<Vec<u8>>;
 
 impl CFormatBytes {
     pub fn parse_from_bytes(bytes: &[u8]) -> Result<Self, CFormatError> {
-        let mut iter = bytes.iter().cloned().enumerate().peekable();
+        let mut iter = bytes.iter().copied().enumerate().peekable();
         Self::parse(&mut iter)
     }
 }
diff --git a/crates/stdlib/src/faulthandler.rs b/crates/stdlib/src/faulthandler.rs
@@ -1012,7 +1012,7 @@ mod decl {
 
         pub fn get_user_signal(signum: usize) -> Option<UserSignal> {
             let guard = USER_SIGNALS.lock();
-            guard.as_ref().and_then(|v| v.get(signum).cloned())
+            guard.as_ref().and_then(|v| v.get(signum).copied())
         }
 
         pub fn set_user_signal(signum: usize, signal: UserSignal) {
diff --git a/crates/vm/src/protocol/buffer.rs b/crates/vm/src/protocol/buffer.rs
@@ -222,7 +222,7 @@ impl BufferDescriptor {
         } else {
             let mut shape_product = 1;
             let has_zero_dim = self.dim_desc.iter().any(|(s, _, _)| *s == 0);
-            for (shape, stride, suboffset) in self.dim_desc.iter().cloned() {
+            for (shape, stride, suboffset) in self.dim_desc.iter().copied() {
                 shape_product *= shape;
                 assert!(suboffset >= 0);
                 // For empty arrays (any dimension is 0), strides can be 0
@@ -251,7 +251,7 @@ impl BufferDescriptor {
             return true;
         }
         let mut sd = self.itemsize;
-        for (shape, stride, _) in self.dim_desc.iter().cloned().rev() {
+        for (shape, stride, _) in self.dim_desc.iter().copied().rev() {
             if shape > 1 && stride != sd as isize {
                 return false;
             }
@@ -267,8 +267,8 @@ impl BufferDescriptor {
         let mut pos = 0;
         for (i, (_, stride, suboffset)) in indices
             .iter()
-            .cloned()
-            .zip_eq(self.dim_desc.iter().cloned())
+            .copied()
+            .zip_eq(self.dim_desc.iter().copied())
         {
             pos += i as isize * stride + suboffset;
         }
@@ -280,8 +280,8 @@ impl BufferDescriptor {
         let mut pos = 0;
         for (i, (shape, stride, suboffset)) in indices
             .iter()
-            .cloned()
-            .zip_eq(self.dim_desc.iter().cloned())
+            .copied()
+            .zip_eq(self.dim_desc.iter().copied())
         {
             let i = i.wrapped_at(shape).ok_or_else(|| {
                 vm.new_index_error(format!("index out of bounds on dimension {i}"))
diff --git a/crates/vm/src/stdlib/_sre.rs b/crates/vm/src/stdlib/_sre.rs
@@ -66,7 +66,7 @@ mod _sre {
     impl SreStr for &[u8] {
         fn slice(&self, start: usize, end: usize, vm: &VirtualMachine) -> PyObjectRef {
             vm.ctx
-                .new_bytes(self.iter().take(end).skip(start).cloned().collect())
+                .new_bytes(self.iter().take(end).skip(start).copied().collect())
                 .into()
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -834,7 +834,7 @@ pub type CFormatBytes = CFormatStrOrBytes<Vec<u8>>;`
`834`	`834`
`835`	`835`	`impl CFormatBytes {`
`836`	`836`	`pub fn parse_from_bytes(bytes: &[u8]) -> Result<Self, CFormatError> {`
`837`		`- let mut iter = bytes.iter().cloned().enumerate().peekable();`
	`837`	`+ let mut iter = bytes.iter().copied().enumerate().peekable();`
`838`	`838`	`Self::parse(&mut iter)`
`839`	`839`	`}`
`840`	`840`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1012,7 +1012,7 @@ mod decl {`
`1012`	`1012`
`1013`	`1013`	`pub fn get_user_signal(signum: usize) -> Option<UserSignal> {`
`1014`	`1014`	`let guard = USER_SIGNALS.lock();`
`1015`		`- guard.as_ref().and_then(\|v\| v.get(signum).cloned())`
	`1015`	`+ guard.as_ref().and_then(\|v\| v.get(signum).copied())`
`1016`	`1016`	`}`
`1017`	`1017`
`1018`	`1018`	`pub fn set_user_signal(signum: usize, signal: UserSignal) {`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ mod _sre {`
`66`	`66`	`impl SreStr for &[u8] {`
`67`	`67`	`fn slice(&self, start: usize, end: usize, vm: &VirtualMachine) -> PyObjectRef {`
`68`	`68`	`vm.ctx`
`69`		`- .new_bytes(self.iter().take(end).skip(start).cloned().collect())`
	`69`	`+ .new_bytes(self.iter().take(end).skip(start).copied().collect())`
`70`	`70`	`.into()`
`71`	`71`	`}`
`72`	`72`	`}`