check __slots__ isidentifier

youknowone · youknowone · commit c29d54a809f0 · 2025-12-27T23:13:19.000+09:00
diff --git a/crates/vm/src/builtins/str.rs b/crates/vm/src/builtins/str.rs
@@ -1336,7 +1336,7 @@ impl PyStr {
     }
 
     #[pymethod]
-    fn isidentifier(&self) -> bool {
+    pub fn isidentifier(&self) -> bool {
         let Some(s) = self.to_str() else { return false };
         let mut chars = s.chars();
         let is_identifier_start = chars.next().is_some_and(|c| c == '_' || is_xid_start(c));
diff --git a/crates/vm/src/builtins/type.rs b/crates/vm/src/builtins/type.rs
@@ -1378,6 +1378,15 @@ impl Constructor for PyType {
                     tuple.try_into_typed(vm)?
                 };
 
+                // Validate that all slots are valid identifiers
+                for slot in slots.iter() {
+                    if !slot.isidentifier() {
+                        return Err(
+                            vm.new_type_error("__slots__ must be identifiers".to_owned())
+                        );
+                    }
+                }
+
                 // Check if __dict__ is in slots
                 let dict_name = "__dict__";
                 let has_dict = slots.iter().any(|s| s.as_str() == dict_name);

Original file line number	Diff line number	Diff line change
`@@ -1336,7 +1336,7 @@ impl PyStr {`
`1336`	`1336`	`}`
`1337`	`1337`
`1338`	`1338`	`#[pymethod]`
`1339`		`- fn isidentifier(&self) -> bool {`
	`1339`	`+ pub fn isidentifier(&self) -> bool {`
`1340`	`1340`	`let Some(s) = self.to_str() else { return false };`
`1341`	`1341`	`let mut chars = s.chars();`
`1342`	`1342`	`let is_identifier_start = chars.next().is_some_and(\|c\| c == '_' \|\| is_xid_start(c));`