Fix clippy warnings and null pointer issues in overlapped module

youknowone · claude · youknowone · commit 4eca2572392d · 2026-01-27T15:10:55.000+09:00
- Add #[allow(dead_code)] to specific OverlappedData variants that store
  buffers which must be kept alive during async operations but aren't
  directly read from Rust code: ReadInto, Write, Accept
- Add #[allow(dead_code)] to WaitNamedPipeAndConnect (reserved for named pipe)
- Add #[allow(clippy::too_many_arguments)] to TransmitFile method
  which follows CPython's API signature
- Fix potential null pointer issues in WSARecvInto, WSASend, WSASendTo,
  and WSARecvFromInto by validating buffer contiguity before use
  (matches CPython behavior which rejects non-contiguous buffers)

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/crates/stdlib/src/overlapped.rs b/crates/stdlib/src/overlapped.rs
@@ -721,13 +721,15 @@ mod _overlapped {
             let mut flags = flags;
             inner.handle = handle as HANDLE;
             let buf_len = buf.desc.len;
+
+            let Some(contiguous) = buf.as_contiguous_mut() else {
+                return Err(vm.new_buffer_error("buffer is not contiguous".to_owned()));
+            };
+
             inner.data = OverlappedData::ReadInto(buf.clone());
 
             let wsabuf = WSABUF {
-                buf: buf
-                    .as_contiguous()
-                    .map(|b| b.as_ptr() as *mut _)
-                    .unwrap_or(std::ptr::null_mut()),
+                buf: contiguous.as_ptr() as *mut _,
                 len: buf_len as u32,
             };
             let mut nread: u32 = 0;
@@ -830,13 +832,15 @@ mod _overlapped {
 
             inner.handle = handle as HANDLE;
             let buf_len = buf.desc.len;
+
+            let Some(contiguous) = buf.as_contiguous() else {
+                return Err(vm.new_buffer_error("buffer is not contiguous".to_owned()));
+            };
+
             inner.data = OverlappedData::Write(buf.clone());
 
             let wsabuf = WSABUF {
-                buf: buf
-                    .as_contiguous()
-                    .map(|b| b.as_ptr() as *mut _)
-                    .unwrap_or(std::ptr::null_mut()),
+                buf: contiguous.as_ptr() as *mut _,
                 len: buf_len as u32,
             };
             let mut written: u32 = 0;
@@ -1218,17 +1222,19 @@ mod _overlapped {
 
             inner.handle = handle as HANDLE;
             let buf_len = buf.desc.len;
+
+            let Some(contiguous) = buf.as_contiguous() else {
+                return Err(vm.new_buffer_error("buffer is not contiguous".to_owned()));
+            };
+
             // Store both buffer and address in OverlappedData to keep them alive
             inner.data = OverlappedData::WriteTo(OverlappedWriteTo {
                 buf: buf.clone(),
                 address: addr_bytes,
             });
 
             let wsabuf = WSABUF {
-                buf: buf
-                    .as_contiguous()
-                    .map(|b| b.as_ptr() as *mut _)
-                    .unwrap_or(std::ptr::null_mut()),
+                buf: contiguous.as_ptr() as *mut _,
                 len: buf_len as u32,
             };
             let mut written: u32 = 0;
@@ -1378,6 +1384,10 @@ mod _overlapped {
             let mut flags = flags.unwrap_or(0);
             inner.handle = handle as HANDLE;
 
+            let Some(contiguous) = buf.as_contiguous_mut() else {
+                return Err(vm.new_buffer_error("buffer is not contiguous".to_owned()));
+            };
+
             let address: SOCKADDR_IN6 = unsafe { std::mem::zeroed() };
             let address_length = std::mem::size_of::<SOCKADDR_IN6>() as i32;
 
@@ -1388,10 +1398,7 @@ mod _overlapped {
             });
 
             let wsabuf = WSABUF {
-                buf: buf
-                    .as_contiguous()
-                    .map(|b| b.as_ptr() as *mut _)
-                    .unwrap_or(std::ptr::null_mut()),
+                buf: contiguous.as_ptr() as *mut _,
                 len: size,
             };
             let mut nread: u32 = 0;
diff --git a/scripts/generate_opcode_metadata.py b/scripts/generate_opcode_metadata.py
@@ -49,7 +49,7 @@ def extract_enum_body(contents: str, enum_name: str) -> str:
     )
 
 
-contents = BYTECODE_FILE.read_text()
+contents = BYTECODE_FILE.read_text(encoding="utf-8")
 enum_body = "\n".join(
     extract_enum_body(contents, enum_name)
     for enum_name in ("Instruction", "PseudoInstruction")
@@ -78,4 +78,4 @@ def extract_enum_body(contents: str, enum_name: str) -> str:
 MIN_INSTRUMENTED_OPCODE = 236
 """
 
-OPCODE_METADATA_FILE.write_text(output)
+OPCODE_METADATA_FILE.write_text(output, encoding="utf-8")
