apply review

youknowone · youknowone · commit 12e54e40309e · 2025-11-15T22:32:04.000+09:00
diff --git a/stdlib/src/ssl/cert.rs b/stdlib/src/ssl/cert.rs
@@ -171,7 +171,7 @@ fn format_ip_address(ip: &[u8]) -> String {
 fn format_asn1_time(time: &x509_parser::time::ASN1Time) -> String {
     let timestamp = time.timestamp();
     DateTime::<Utc>::from_timestamp(timestamp, 0)
-        .unwrap()
+        .expect("ASN1Time must be valid timestamp")
         .format("%b %e %H:%M:%S %Y GMT")
         .to_string()
 }
@@ -867,7 +867,7 @@ impl ServerCertVerifier for HostnameIgnoringVerifier {
         // The inner verifier will validate certificate chain, trust anchors, etc.
         // but may fail on hostname mismatch - we'll catch and ignore that error
         let dummy_hostname = extract_first_dns_name(end_entity)
-            .unwrap_or_else(|| ServerName::try_from("localhost").unwrap());
+            .unwrap_or_else(|| ServerName::try_from("localhost").expect("localhost is valid"));
 
         // Call inner verifier for full certificate validation
         match self.inner.verify_server_cert(
diff --git a/stdlib/src/ssl/compat.rs b/stdlib/src/ssl/compat.rs
@@ -927,9 +927,8 @@ pub(super) fn create_client_config(options: ClientConfigOptions) -> Result<Clien
                 > = Arc::new(HostnameIgnoringVerifier::new_with_verifier(verifier));
 
                 // Apply Strict verifier wrapper once at the end if needed
-                if options.verify_flags != 0 {
-                    use crate::ssl::cert::StrictCertVerifier;
-                    Arc::new(StrictCertVerifier::new(
+                if options.verify_flags & VERIFY_X509_STRICT != 0 {
+                    Arc::new(crate::ssl::cert::StrictCertVerifier::new(
                         hostname_ignoring_verifier,
                         options.verify_flags,
                     ))
