ENH: Auto-Detection of Pressure Conversion Factor#966
Open
MateusStano wants to merge 2 commits into
Open
Conversation
MateusStano
added
Enhancement
MateusStano
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #966 +/- ##
===========================================
+ Coverage 80.27% 81.10% +0.83%
===========================================
Files 104 113 +9
Lines 12769 14575 +1806
===========================================
+ Hits 10250 11821 +1571
- Misses 2519 2754 +235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #955 a pressure unit conversion was added to the
set_atmospheric_model. This fixed the pressure units for the new "Forecast" models added in #943. However, currently the default pressure unit is "Pa" when it used to be "hPa", this broke the definition of atmospheric models defined by files (such as reanalysis usage). One example of this breaking can be found incamoes_flight_sim.ipynbThis PR adds the functionality to automatically set the pressure unit based on the File/Model type
Breaking change