Skip to content

TST: skip tests for draft PRs and non-Python files - #362

Merged
MateusStano merged 1 commit into
masterfrom
tst/skip-drafts-non-py
May 15, 2023
Merged

MateusStano merged 1 commit into
masterfrom
tst/skip-drafts-non-py

Conversation

@giovaniceotto

Copy link
Copy Markdown
Member

Pull request type

  • ReadMe, Docs and GitHub maintenance

Pull request checklist

  • Spelling has been verified
  • Code docs are working correctly

What is the current behavior?

GitHub Actions runs a PyTest workflow on draft PRs and even when non python files are updated, wasting resources and causing annoyances.

What is the new behavior?

  • When a PR is in draft mode, no tests are run, saving resources, but the workflow fails indicating that they need to be run later.
  • When no python files are updated, no tests are run,

Does this introduce a breaking change?

  • No

Other information

References:

@giovaniceotto giovaniceotto added the C.I. Continuous Integration (Workflows and actions) label May 8, 2023
@giovaniceotto giovaniceotto self-assigned this May 8, 2023
@github-actions
github-actions Bot requested a review from Gui-FernandesBR May 8, 2023 03:03

@Gui-FernandesBR Gui-FernandesBR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@MateusStano
MateusStano changed the base branch from master to beta/v1.0.0 May 15, 2023 23:04
@MateusStano
MateusStano changed the base branch from beta/v1.0.0 to master May 15, 2023 23:06
@MateusStano
MateusStano merged commit 171e61f into master May 15, 2023
@Gui-FernandesBR
Gui-FernandesBR deleted the tst/skip-drafts-non-py branch May 26, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C.I. Continuous Integration (Workflows and actions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants