Skip to content

ENH: list NOAA atmosphere datasets and fetch latest (#660) - #1136

Merged
Gui-FernandesBR merged 2 commits into
RocketPy-Team:developfrom
thatrandomasiandev:enh/660-list-noaa-datasets
Aug 15, 2026
Merged

Gui-FernandesBR merged 2 commits into
RocketPy-Team:developfrom
thatrandomasiandev:enh/660-list-noaa-datasets

Conversation

@thatrandomasiandev

Copy link
Copy Markdown

Summary

  • Adds best-effort helpers to list NCEP atmosphere collections and per-collection run identifiers from the Unidata THREDDS catalogs RocketPy already uses for GFS/NAM/RAP/HRRR/AIGFS (list_noaa_atmosphere_datasets, list_noaa_dataset_identifiers).
  • Adds convenience APIs to resolve and open the latest collection run via OPeNDAP (get_latest_noaa_opendap_url, fetch_latest_noaa_dataset) without changing Environment.
  • Documents limitations: NOMADS OPeNDAP is retired, so discovery scrapes THREDDS XML catalogs (layout can change); “download” means opening the remote dataset handle (same pattern as existing fetchers), not writing a local GRIB file.

Fixes #660

Test plan

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest tests/unit/environment/test_fetchers.py -q (25 passed; catalog/HTTP mocked, no live NOAA)

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.25000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (dc5f81f) to head (9e5e2b0).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/fetchers/noaa_catalog.py 81.13% 30 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1136      +/-   ##
===========================================
- Coverage    84.47%   84.44%   -0.03%     
===========================================
  Files          130      131       +1     
  Lines        17331    17491     +160     
===========================================
+ Hits         14641    14771     +130     
- Misses        2690     2720      +30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thatrandomasiandev and others added 2 commits August 15, 2026 12:06
Collapse the RuntimeError message and the test assertion the formatter
wants on one line. No behaviour change.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Gui-FernandesBR
Gui-FernandesBR force-pushed the enh/660-list-noaa-datasets branch from f9c92f4 to 9e5e2b0 Compare August 15, 2026 15:06
@Gui-FernandesBR
Gui-FernandesBR merged commit 24861fd into RocketPy-Team:develop Aug 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: List all the available datasets of NOAA's server. Easily download the latest dataset.

2 participants