Enhancement/#61 - Json support - #62
Conversation
Fix Deregister RocketAttributeCommand (2s)
|
I fixed branch conflicts, next time make sure to use the base repo as RMFix not SmartlyDressedGames/Legally-Distinct-Missile |
|
Since we now have |
|
Fix Deregister RocketAttributeCommand is useful in this PR since we lost this change by our latest changes in other PRs |
It is fully compatible with older plugins. But new plugins that have JSON comments, will not work with older versions of RM. |
Ok, nice to hear that |
| public void AddRange(IEnumerable<TranslationListEntry> collection) | ||
| { | ||
| translations.AddRange(collection); | ||
| } | ||
|
|
||
| public void AddRange(TranslationList collection) | ||
| { | ||
| translations.AddRange(collection.translations); | ||
| } | ||
|
|
There was a problem hiding this comment.
Wouldn't it be a breaking change? Maybe make sense to have same methods as before, just in case
There was a problem hiding this comment.
I don't think so, have you ever seen a plugin that uses that method to add translations?
There was a problem hiding this comment.
Maybe you're right that you and I didn't saw that someone used/use it, but I still think it makes sense to keep it, just in case, who knows, maybe someone used it or still use
There was a problem hiding this comment.
Added those methods back in the latest commit
4 participants
#61