[RELEASE] Merge BETA into MASTER by rafaelks · Pull Request #2596 · RocketChat/Rocket.Chat.iOS

rafaelks · 2019-03-20T14:17:14Z

@RocketChat/ios

… into feat/record_audio.1312

…feature/directory.2290

Some fixes and updates

😠 some dumb mistakes 😠

Status now updates after selecting it, in the profile

[FIX] Status not updated immediately after selecting

[I18N] Update Localizable.strings

…feature/directory.2290

…trings

…loader

[FIX] Clear listeners for dynamic value in notifications

[IMPROVEMENT] Change theme for MBProgressHUD

[IMPROVEMENT] Allow scrolling of chat title if it doesn’t fit

[i18n] Add missing polish translations

[IMPROVEMENT] Adjust wording of Members in Directory

…ontroller_audio_sounds [CHORE] Update RocketChatViewController with audio recorder feedback sounds

[FIX] Refactor EmojiPickerViewController and fix memory leak on iPhone

[CHORE] Update SDK with haptic feedback working again

[CHORE] Merge DEVELOP into BETA

houndci-bot · 2019-03-27T21:05:46Z

        let avatarURL = user.avatarURL(auth)
        XCTAssertNotNil(avatarURL, "url is valid")
-        XCTAssertEqual(avatarURL?.absoluteString, "https://open.rocket.chat/avatar/\(user.username ?? "")?format=jpeg", "avatar url is valid")
+        XCTAssertEqual(avatarURL?.absoluteString, "https://open.rocket.chat/avatar/\(user.username ?? "")?format=jpeg&rc_uid=userId123&rc_token=token123", "avatar url is valid")


Line Length Violation: Line should be 120 characters or less: currently 177 characters (line_length)

houndci-bot · 2019-03-27T21:05:46Z

        let avatarURL = user.avatarURL(auth)
        XCTAssertNotNil(avatarURL, "url is valid")
-        XCTAssertEqual(avatarURL?.absoluteString, "https://open.rocket.chat/avatar/user-username?format=jpeg", "avatar url is valid")
+        XCTAssertEqual(avatarURL?.absoluteString, "https://open.rocket.chat/avatar/user-username?format=jpeg&rc_uid=userId123&rc_token=token123", "avatar url is valid")


Line Length Violation: Line should be 120 characters or less: currently 168 characters (line_length)

houndci-bot · 2019-03-27T21:05:46Z

+            separatorView.leadingAnchor.constraint(equalTo: discardButton.trailingAnchor, constant: Consts.separatorViewLeading),
+            separatorView.centerYAnchor.constraint(equalTo: centerYAnchor),
+
+            sendButton.leadingAnchor.constraint(equalTo: separatorView.trailingAnchor, constant: Consts.sendButtonLeading),


Line Length Violation: Line should be 120 characters or less: currently 123 characters (line_length)

houndci-bot · 2019-03-27T21:05:47Z

+            discardButton.leadingAnchor.constraint(equalTo: audioView.trailingAnchor, constant: Consts.discardButtonLeading),
+            discardButton.centerYAnchor.constraint(equalTo: centerYAnchor),
+
+            separatorView.leadingAnchor.constraint(equalTo: discardButton.trailingAnchor, constant: Consts.separatorViewLeading),


Line Length Violation: Line should be 120 characters or less: currently 129 characters (line_length)

houndci-bot · 2019-03-27T21:05:47Z

+            audioView.topAnchor.constraint(equalTo: topAnchor, constant: Consts.audioViewTop),
+            audioView.bottomAnchor.constraint(equalTo: bottomAnchor, constant: Consts.audioViewBottom),
+
+            discardButton.leadingAnchor.constraint(equalTo: audioView.trailingAnchor, constant: Consts.discardButtonLeading),


Line Length Violation: Line should be 120 characters or less: currently 125 characters (line_length)

houndci-bot · 2019-03-27T21:05:49Z

+
+        if userData as? String == "PreviewAudioView" {
+            let previewAudioView: PreviewAudioView
+            if let previewAudioView_ = view.subviews.first as? PreviewAudioView {


Identifier Name Violation: Variable name should only contain alphanumeric characters: 'previewAudioView_' (identifier_name)

houndci-bot · 2019-03-27T21:05:49Z

+
+        if userData as? String == "RecordAudioView" {
+            let recordAudioView: RecordAudioView
+            if let recordAudioView_ = view.subviews.first as? RecordAudioView {


Identifier Name Violation: Variable name should only contain alphanumeric characters: 'recordAudioView_' (identifier_name)

houndci-bot · 2019-03-27T21:05:50Z

+        }
+    }
+
+    func composerView(_ composerView: ComposerView, event: UIEvent, eventType: UIControl.Event, happenedInButton button: ComposerButton) {


Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)

houndci-bot · 2019-03-27T21:05:50Z

    func composerViewDidChangeSelection(_ composerView: ComposerView) { }
    func composerView(_ composerView: ComposerView, didUpdateAddonView view: UIView?, at slot: ComposerAddonSlot, index: UInt) { }
-    func composerView(_ composerView: ComposerView, didTapButton button: ComposerButton) { }
+    func composerView(_ composerView: ComposerView, event: UIEvent, eventType: UIControl.Event, happenedInButton button: ComposerButton) { }


Line Length Violation: Line should be 120 characters or less: currently 140 characters (line_length)

houndci-bot · 2019-03-27T21:05:50Z

+     Tells the delegate some event happened in the button.
     */
-    func composerView(_ composerView: ComposerView, didTapButton button: ComposerButton)
+    func composerView(_ composerView: ComposerView, event: UIEvent, eventType: UIControl.Event, happenedInButton button: ComposerButton)


Line Length Violation: Line should be 120 characters or less: currently 136 characters (line_length)

…ed_by_gabriel [CHORE] UI adjustments on the list of chats

… and more

[CHORE] Update RocketChatViewController with better audio feedback, bug fixes and more

[I18N] Greek translation update 2019-03-30

…nticated [FIX] Auth params into channel avatar URL

…stMessage object

[FIX] User is loosing roles on mapping lastMessage

[CHORE] UI adjustments on quotes & replies

[CHORE] Merge DEVELOP into BETA

cardoso and others added 30 commits January 10, 2019 13:56

Initial commit for record audio feature

21a8dfb

Record and send audio

8cc4ab5

Implement PreviewAudioView

2d2c1ff

Finish audio message uploading flow

bb70ff5

Support themes in audio composer

b53da4c

Adjust audio composer colors

0a39bb0

Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.iOS…

23b5c88

… into feat/record_audio.1312

Update pods

be9ce4d

Add support to channels on the result & pagination properties

3031b89

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.iOS into …

839eb0b

…feature/directory.2290

Add Directory item into the list of subscriptions

508d99a

Code adjustments & start implementing the Directory controller

462c852

Presentation of the controller, search bar adjustments & fixes

574f7e7

Sync rcvc with feat/audio_record branch

3fd67bb

Fixed problem with non 24H formatting clock

ad4e307

Update Localizable.strings

3e3d5c7

Some fixes and updates

Update Localizable.strings

e155f4c

😠 some dumb mistakes 😠

Resolved #2075

5866fdf

Status now updates after selecting it, in the profile

Merge pull request #2582 from snuff4/bug/status_update

84cc48d

[FIX] Status not updated immediately after selecting

Fixed typo on guardadas

7251a93

Merge pull request #2576 from TheMythPT/patch-2

576f950

[I18N] Update Localizable.strings

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat.iOS into …

cf8ee0d

…feature/directory.2290

Create header to change filter between Users, Channels and Federation

81d0ed6

Create cells layouts to present Channels & Users from Directory

70969b1

Update RocketChatViewController

b368cd3

Present Users, Channels lists with paginated results, translate all s…

7012956

…trings

add initial translate file

9b25c93

modified main translate

7c04464

add other translate

6d886fc

Code adjustments to present Federation, number of users translated & …

5e439bc

…loader

rafaelks and others added 13 commits March 22, 2019 08:29

Merge pull request #2602 from artrmz/fix/notifications-listeners-leak

2e1cfb5

[FIX] Clear listeners for dynamic value in notifications

Merge pull request #2600 from snuff4/MBProgressHUDTheme

cec6295

[IMPROVEMENT] Change theme for MBProgressHUD

Merge pull request #2603 from artrmz/feature/scrollable-chat-titles

1ba1aca

[IMPROVEMENT] Allow scrolling of chat title if it doesn’t fit

Merge pull request #2601 from artrmz/chore/i18n-polish

4a9b767

[i18n] Add missing polish translations

Resolved conflicts with develop

51677cd

Merge pull request #2604 from RocketChat/chore/adjust_members_string

5a7958c

[IMPROVEMENT] Adjust wording of Members in Directory

Refactor EmojiPickerViewController and fix memory leak on iPhone

866c639

Add audio sounds feedback via RocketChatViewController

67fd42d

Merge pull request #2609 from RocketChat/chore/update_rocketchatviewc…

8e8b5ca

…ontroller_audio_sounds [CHORE] Update RocketChatViewController with audio recorder feedback sounds

Merge pull request #2608 from artrmz/fix/emoji-picker-leaks

7979c2b

[FIX] Refactor EmojiPickerViewController and fix memory leak on iPhone

Update SDK with haptic feedback working again

41fb80a

Merge pull request #2610 from RocketChat/chore/update_rocketchat_sdk

ecad166

[CHORE] Update SDK with haptic feedback working again

Merge pull request #2611 from RocketChat/develop

42fda31

[CHORE] Merge DEVELOP into BETA

houndci-bot reviewed Mar 27, 2019

View reviewed changes

rafaelks and others added 15 commits March 28, 2019 15:46

UI adjustments on the list of chats

ac131a5

Merge branch 'develop' into chore/ui_adjustments_requested_by_gabriel

b8573f7

Merge pull request #2618 from RocketChat/chore/ui_adjustments_request…

7861286

…ed_by_gabriel [CHORE] UI adjustments on the list of chats

Update RocketChatViewController with better audio feedback, bug fixes…

d810531

… and more

Pass auth values into channel avatar URL as well

eed32d3

Merge pull request #2619 from RocketChat/chore/update_sdk_fixes

5a33e64

[CHORE] Update RocketChatViewController with better audio feedback, bug fixes and more

Greek translation update 2019-03-30

b19c812

Greek translation update 2019-03-30b

3323df6

Merge pull request #2623 from kmav/kmav/greek-20190330

74f5c46

[I18N] Greek translation update 2019-03-30

Merge pull request #2620 from RocketChat/bug/avatar_url_channel_authe…

e119409

…nticated [FIX] Auth params into channel avatar URL

Adjust spacing & color of Quotes

42f7942

Check for the existense of the user before creating a new one from la…

b23dbb7

…stMessage object

Merge pull request #2624 from RocketChat/bug/user_loses_roles

45bc26a

[FIX] User is loosing roles on mapping lastMessage

Merge pull request #2626 from RocketChat/chore/adjustments_ui

ac1a172

[CHORE] UI adjustments on quotes & replies

Merge pull request #2621 from RocketChat/develop

066dfba

[CHORE] Merge DEVELOP into BETA

rafaelks merged commit 201fe64 into master Apr 2, 2019

Navigation Menu

Repository navigation

[RELEASE] Merge BETA into MASTER - #2596

[RELEASE] Merge BETA into MASTER#2596
rafaelks merged 90 commits into
masterfrom
beta

rafaelks commented Mar 20, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

houndci-bot Mar 27, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

rafaelks commented Mar 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants