Repository navigation
Conversation
Did you missed me? 😛 Translated the remaining strings. 😁
This is probably the only approach I can find as `Favoritar/Desfavoritar` doesn't exist, at least in pt_PT 😛
Fixed some left typos 😄
[FIX][RCVC] Reintroduce "loading messages" indication
[I18N] Update Localizable.strings
[IMPROVEMENT] Show emojis and markdown in reply/quote popup
[IMPROVEMENT] Remove @ and add left & right spacing to mentions
[NEW] Copy message permalink
…feature/jitsi_integration
[NEW] Support announcements
[CHORE] Remove unused code, resolve some SwiftLint warnings & suppress couple.
[CHORE] Remove @ from file attachments, autocomplete & quotes
…iption [FIX] View models deallocation & Subscription object mapping fixing on updates
…sword.2505 [FIX] Fixed color into forgot password button
[FIX] Fixed issue on connecting to a server & having an invalid server after all in some edge cases
…_details_channel [CHORE] Hide empty information from Channel Information
[RELEASE] Merge DEVELOP into BETA
…cons [NEW] Update Video Call icons on Jitsi SDK
[RELEASE] Merge DEVELOP into BETA
[CHORE] Update RocketChatViewController & DifferenceKit
[CHORE] Disable Video/Audio call (CallKit) in China region
[RELEASE] Merge DEVELOP into BETA
|
|
||
| XCTAssertEqual( | ||
| result.string, | ||
| "Hi \u{00a0}rafael.kellermann\u{00a0}, how are you doing? Is everyone \u{00a0}here\u{00a0} having a great day? How about you \u{00a0}filipe.alvarenga\u{00a0}? Wish you \u{00a0}all\u{00a0} a happy Christmas :) from \u{00a0}matheus.cardoso\u{00a0}", |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 259 characters (line_length)
| // swiftlint:disable function_body_length | ||
| func testMentionParsing() { | ||
| let string = "Hi @rafael.kellermann, how are you doing? " + | ||
| "Is everyone @here having a great day? How about you @filipe.alvarenga? Wish you @all a happy Christmas :) from @matheus.cardoso" |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 150 characters (line_length)
| messageButton?.setTitle(model.messageButtonText, for: .normal) | ||
| voiceCallButton?.setTitle(model.voiceCallButtonText, for: .normal) | ||
|
|
||
| videoCallButton?.isHidden = !(AuthSettingsManager.settings?.isJitsiEnabled ?? false && AppManager.isVideoCallAvailable) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 127 characters (line_length)
| self.reply(to: message) | ||
| }) | ||
|
|
||
| let permalink = UIAlertAction(title: localized("chat.message.actions.permalink"), style: .default, handler: { _ in |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 122 characters (line_length)
| let messageType: String? | ||
|
|
||
| init(id: String, roomId: String, text: String) { | ||
| init(id: String, roomId: String, text: String, messageType: String? = nil) { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
| } | ||
|
|
||
| func sendMessage(text: String, subscription: UnmanagedSubscription, id: String = String.random(18), user: User? = AuthManager.currentUser(), realm: Realm? = Realm.current) { | ||
| func sendMessage(text: String, internalType: String? = nil, subscription: UnmanagedSubscription, id: String = String.random(18), user: User? = AuthManager.currentUser(), realm: Realm? = Realm.current) { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
Line Length Violation: Line should be 120 characters or less: currently 206 characters (line_length)
| moved.append((source: mapIndex(sourceIndex - deleteOffset), target: mapIndex(targetIndex))) | ||
| } | ||
| } else { | ||
| } |
There was a problem hiding this comment.
Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)
| } else { | ||
| updatedElements?(targetElement) | ||
| undeletedElements?(targetElement) | ||
| } |
There was a problem hiding this comment.
Statement Position Violation: Else and catch should be on the same line, one space after the previous declaration. (statement_position)
@RocketChat/ios