ci: run Build PR pipeline for PRs based on feature branches - #7417
Merged
Conversation
GitHub matches on.pull_request.branches against the base ref, and the '*' glob does not match refs containing a slash. PRs whose base is a feature branch (e.g. a stacked PR targeting feat/...) never ran the build pipeline. Use '**' so the filter matches across slashes. Claude-Session: https://claude.ai/code/session_01SVjvyuH3Ku5wZDxKSCfHY7
diegolmello
had a problem deploying
to
approve_e2e_testing
June 19, 2026 14:01 — with
GitHub Actions
Failure
Contributor
WalkthroughThe ChangesCI Branch Glob Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
had a problem deploying
to
android_build
June 19, 2026 14:04 — with
GitHub Actions
Failure
Rohit3523
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
GitHub matches
on.pull_request.branchesagainst the base ref, and the'*'glob does not match refs containing a slash. Any PR whose base is a feature branch (e.g. a stacked PR targetingfeat/...) never triggered the Build PR pipeline (ESLint/Test, Android build, iOS build, E2E) — only PRs based directly ondevelopbuilt.Changed the filter to
'**', which matches across slashes, so stacked PRs run the pipeline.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1306
How to test or reproduce
Open a PR whose base is a slashed feature branch and confirm the Build PR workflow runs.
Types of changes
https://claude.ai/code/session_01SVjvyuH3Ku5wZDxKSCfHY7
Summary by CodeRabbit
Release Notes
This release contains infrastructure updates with no user-facing changes.