Skip to content

ci: run Build PR pipeline for PRs based on feature branches - #7417

Merged
diegolmello merged 1 commit into
developfrom
fix/build-pr-feature-branch-base
Jun 19, 2026
Merged

ci: run Build PR pipeline for PRs based on feature branches#7417
diegolmello merged 1 commit into
developfrom
fix/build-pr-feature-branch-base

Conversation

@diegolmello

@diegolmello diegolmello commented Jun 19, 2026

Copy link
Copy Markdown
Member

Proposed changes

GitHub matches on.pull_request.branches against the base ref, and the '*' glob does not match refs containing a slash. Any PR whose base is a feature branch (e.g. a stacked PR targeting feat/...) never triggered the Build PR pipeline (ESLint/Test, Android build, iOS build, E2E) — only PRs based directly on develop built.

Changed the filter to '**', which matches across slashes, so stacked PRs run the pipeline.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1306

How to test or reproduce

Open a PR whose base is a slashed feature branch and confirm the Build PR workflow runs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

https://claude.ai/code/session_01SVjvyuH3Ku5wZDxKSCfHY7

Summary by CodeRabbit

Release Notes

This release contains infrastructure updates with no user-facing changes.

  • Chores
    • Updated CI/CD workflow configuration.

GitHub matches on.pull_request.branches against the base ref, and the
'*' glob does not match refs containing a slash. PRs whose base is a
feature branch (e.g. a stacked PR targeting feat/...) never ran the
build pipeline. Use '**' so the filter matches across slashes.

Claude-Session: https://claude.ai/code/session_01SVjvyuH3Ku5wZDxKSCfHY7
@diegolmello
diegolmello had a problem deploying to approve_e2e_testing June 19, 2026 14:01 — with GitHub Actions Failure
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The pull_request trigger in .github/workflows/build-pr.yml has its branches glob pattern changed from '*' (matches only top-level branch names with no slashes) to '**' (matches branch names at any depth, including those containing /).

Changes

CI Branch Glob Fix

Layer / File(s) Summary
PR trigger branch glob update
.github/workflows/build-pr.yml
on.pull_request.branches filter changed from '*' to '**', extending matching to branch names that contain path separators (e.g., feature/my-branch).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title 'ci: run Build PR pipeline for PRs based on feature branches' directly describes the main change: enabling the Build PR pipeline to run for PRs targeting feature branches with slashes, which is the core issue addressed in this PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1306: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello changed the title fix: run Build PR pipeline for PRs based on feature branches ci: run Build PR pipeline for PRs based on feature branches Jun 19, 2026
@diegolmello
diegolmello merged commit bf1dbdb into develop Jun 19, 2026
5 of 8 checks passed
@diegolmello
diegolmello deleted the fix/build-pr-feature-branch-base branch June 19, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants