Skip to content

Conversation

@Undid-Iridium
Copy link
Contributor

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

  1. KemonoRipper - New
  2. DanbooruRipper - Fix
  3. AbstractJsonRipper - Change to use OkHttp3

Testing

Required verification:

  • I've verified that there are no regressions in gradlew test (there are no new failures or errors) (As far as I can tell).
  • I've verified that this change works as intended.
image
  • Downloads all relevant content. (502 can occur but it retries but I can't fix slow.)
  • Downloads content from multiple pages (as necessary or appropriate).
  • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
    (I would argue it should have the name of the artist then ID but..)
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified). (As far as I can tell).

Optional but recommended:

  • I've added a unit test to cover my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant