Skip to content

Conversation

@0x1f595
Copy link
Contributor

@0x1f595 0x1f595 commented Apr 25, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix

Description

This updates the Mangadex ripper to make it a bit more relaxed on what URLs it considers valid and can rip. It now allows a "www" prefix on the URL, and correctly rips whole chapters when a page URL within a chapter is given.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@metaprime metaprime changed the base branch from master to main January 6, 2025 14:13
@metaprime
Copy link
Contributor

metaprime commented Feb 2, 2025

Tried merging this PR together with main but it looks like the implementation calls an API that maybe doesn't work anymore, so a bigger fix for this ripper is needed.

See #2091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants