Skip to content

Conversation

@cyian-1756
Copy link
Collaborator

…tory is false

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

I added line in DownloadFileThread.java that check if the file being downloaded exists on disk and if so adds 1 to alreadyDownloadedUrls

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@cyian-1756
Copy link
Collaborator Author

The failed test passed locally

@cyian-1756 cyian-1756 changed the title history.end_rip_after_already_seen now works even if remember.url_his… [don't merge] history.end_rip_after_already_seen now works even if remember.url_his… Jan 9, 2019
@metaprime metaprime changed the base branch from master to main January 6, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

history.end_rip_after_already_seen only works if remember.url_history is true

1 participant