docs(secrets): correct the value-location prose the DB store obsoleted - #1223
Open
rigel-mintaka wants to merge 1 commit into
Open
docs(secrets): correct the value-location prose the DB store obsoleted#1223rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
Two docs still claimed secret values live only in the provider and are never persisted. That is false for user secrets now: their values are AES-256-GCM ciphertext on the secrets row, decrypted through StoreResolver. It stays true for boot/server secrets, whose names live in a physically separate table, so the prose states the split rather than one blanket rule. Also replaces the record's line-number citations with the rulings they mean. The record has grown past those offsets, so each already pointed at the wrong text; D8 gates a tenant-scoped write on an admin and D9 rules the scope selector, neither of which is the user-only gate they were cited for. Refs RIG-3655 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
added this pull request to stack #1188
September 13, 2026 23:55
|
Compass engineering docs preview: https://compass-server-rig-3655-t7-d.compass-eng-docs.pages.dev Deployed from |
mattwilkinsonn
approved these changes
Sep 14, 2026
|
❌ This stack could not start testing because there was a merge conflict. See more details here.
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 4 PRs:
mainTwo docs still claimed secret values live only in the provider and are never
persisted. That is false for user secrets now: their values are AES-256-GCM
ciphertext on the secrets row, decrypted through StoreResolver. It stays true
for boot/server secrets, whose names live in a physically separate table, so
the prose states the split rather than one blanket rule.
Also replaces the record's line-number citations with the rulings they mean.
The record has grown past those offsets, so each already pointed at the wrong
text; D8 gates a tenant-scoped write on an admin and D9 rules the scope
selector, neither of which is the user-only gate they were cited for.
Refs RIG-3655
Co-authored-by: Matt Wilkinson matt@rigel.build