Skip to content

Ballad Lint and Test Action (WIP) - #15

Merged
BD103 merged 4 commits into
masterfrom
ballad-action
May 30, 2021
Merged

Ballad Lint and Test Action (WIP)#15
BD103 merged 4 commits into
masterfrom
ballad-action

Conversation

@BD103

@BD103 BD103 commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Finally adding Continuous Integration! I have designed a Python Package that simulates installing from a poetry.lock file. It's called Ballad. Here's what I did:

  • Created standard Github Action
  • Added linter with Black, Isort, and Flake8
  • It actually works!
  • Only runs for the master branch (which can be changed)
  • Because it's my project, I can add features that are requested

@kokonut27

kokonut27 commented May 28, 2021

Copy link
Copy Markdown
Contributor

@BD103, is Ballad basically like pip? And I'm super sorry for not contributing on this much, I'm just busy with other things and I don't exactly know how to contribute that much yet with this kind of stuff.

@BD103

BD103 commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

Ballad is a program that simulates the installation process of Poetry. Because I have issues with the CI, this is a workaround that should do the same thing. We'll just have to see if it works!

@BD103
BD103 marked this pull request as ready for review May 28, 2021 17:49
@BD103
BD103 requested review from kokonut27 and rayhanadev May 28, 2021 17:50
@BD103 BD103 self-assigned this May 28, 2021
@BD103 BD103 linked an issue May 28, 2021 that may be closed by this pull request
[REQUEST] ~ Github Actions CI #11
Closed
@BD103 BD103 added Priority: LOW Projects that don't need to be completed by the next release Status: IN PROGRESS Working on it Type: IMPROVEMENT Improve an existing feature labels May 28, 2021
@BD103 BD103 mentioned this pull request May 28, 2021
Closed
@darkdarcool

darkdarcool commented May 28, 2021

Copy link
Copy Markdown
Contributor

This looks great to me!

@BD103
BD103 requested a review from darkdarcool May 28, 2021 18:18
@BD103

BD103 commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

@darkdarcool Oop forgot to request review :^

darkdarcool
darkdarcool suggested changes May 28, 2021
View reviewed changes

@darkdarcool darkdarcool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But fix the name, I really hate it.

Comment thread .github/workflows/lint.yml Outdated
@darkdarcool

darkdarcool commented May 28, 2021

Copy link
Copy Markdown
Contributor

also @BD103, I think I'll just give reviews on work, and testing is something I'm good at, and maybe I could do the talk leaderboard part after you do user part to see how I would do it?

@BD103

BD103 commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

also @BD103, I think I'll just give reviews on work, and testing is something I'm good at, and maybe I could do the talk leaderboard part after you do user part to see how I would do it?

Sure, that works for me. Talk to RayhanADev about the queries necessary to get all that information.

@darkdarcool

darkdarcool commented May 28, 2021

Copy link
Copy Markdown
Contributor

I did, but I'll probably talk to him again, and I'll tinker with graphql every now and then. is there anything that you need me to do now tho?

@BD103

BD103 commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

Nope, thanks!

@darkdarcool

darkdarcool commented May 28, 2021

Copy link
Copy Markdown
Contributor

ok, noice! Make sure to tell me when to come in and work!

@darkdarcool

darkdarcool commented May 28, 2021

Copy link
Copy Markdown
Contributor

Also @BD103, should I add myself to the readme of people who are contributors, or not? Just asking because I just saw.

@BD103
fix(workflow): rename lint.yml to balladtest.yml
89f5aed 
- This also applies to the workflow name.
@BD103
BD103 requested a review from darkdarcool May 29, 2021 13:43
darkdarcool
darkdarcool approved these changes May 29, 2021
View reviewed changes

@darkdarcool darkdarcool left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

kokonut27
kokonut27 approved these changes May 29, 2021
View reviewed changes

@kokonut27 kokonut27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@BD103

BD103 commented May 30, 2021

Copy link
Copy Markdown
Contributor Author

@rayhanadev please approve when you have a chance.

@rayhanadev

rayhanadev commented May 30, 2021

Copy link
Copy Markdown

@rayhanadev please approve when you have a chance.

Sorry my bad, I鈥檒l take a look but for future PR鈥檚 this week don鈥檛 count on an immediate response I鈥檒l be studying until Thursday ;D

rayhanadev
rayhanadev approved these changes May 30, 2021
View reviewed changes

@rayhanadev rayhanadev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkdarcool

darkdarcool commented May 30, 2021

Copy link
Copy Markdown
Contributor

@BD103, @rayhanadev gave the green light, we can merge!

@BD103

BD103 commented May 30, 2021

Copy link
Copy Markdown
Contributor Author

Ok, good luck with the exams! Merging.

@BD103
BD103 merged commit 774130e into master May 30, 2021
@BD103
BD103 deleted the ballad-action branch May 30, 2021 18:46
@darkdarcool

darkdarcool commented May 30, 2021

Copy link
Copy Markdown
Contributor

Noice

@kokonut27

kokonut27 commented May 31, 2021

Copy link
Copy Markdown
Contributor

Yas

@BD103 BD103 added Status: COMPLETED Finished something and removed Status: IN PROGRESS Working on it labels May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rayhanadev rayhanadev rayhanadev approved these changes
@kokonut27 kokonut27 kokonut27 approved these changes
+1 more reviewer
@darkdarcool darkdarcool darkdarcool approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BD103 BD103

Labels

Priority: LOW Projects that don't need to be completed by the next release Status: COMPLETED Finished something Type: IMPROVEMENT Improve an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REQUEST] ~ Github Actions CI

4 participants

@BD103 @kokonut27 @darkdarcool @rayhanadev