Open
Conversation
Member
|
Hey, Thanks a lot for taking the time to refactor several code sections and describing your changes so clearly. Looks very good at first glance. I'll take a closer look at the changes as soon as possible. Best regards, |
Author
|
Thank you so much for your kind words. This refactoring was a part of my course assignment and it will be really beneficial for my grades if my pull request gets accepted by the end of this week (deadline for assignment) as it will suggest that I have done great job in this assignment. I really hope that everything is correct and my request gets accepted. Thank you so much, |
Member
Apart from that, it looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Variable
The variable json did not signify what the json was for and hence, it was renamed.
Location: Line 252 in GitlabDataGrabber.java
Extract Method
The code to get a URI was repeated in most of the methods in class GithubDataGrabber.java and hence, the method getUri() was extracted
Location: GithubDataGrabber.java
Extract Class
The class ApiGrabber was performing two responsibilities: managing repositories and managing analysis services. Hence, the APIs for Analysis were extracted in a separate class
Location: ApiAnalysisGrabber.java
Move method
Moved method getFieldDeclarationByLineNumber() from RefactoringHelper.java to RefactoringModifier.java as it was only used once in the class RefactoringModifier.java
Replace conditional with polymorphism
All the methods contained switch cases for each ApiGrabber, hence created an interface named ApiGrabberInterface
Location: ApiGrabberInterface.java