Skip to content

MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-… #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AvivDavid23 merged 3 commits into from
Feb 9, 2026
Merged

MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-… #1503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c55c2c3
MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-…
AvivDavid23 Feb 6, 2026
408353e
.
AvivDavid23 Feb 8, 2026
06a26b6
use old setuptools
AvivDavid23 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/event-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,31 @@ jobs:
id: set-env
run: |
echo "redis-ref=6.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
Copy link

@cursor cursor bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI matrix expanded from 4 to 11 OSes without documentation

Medium Severity

The os parameter was removed from build-linux-x64 and build-linux-arm64 jobs, causing them to use defaults from flow-linux.yml. This expands the CI matrix from 4 OSes (jammy, rocky9, amazonlinux2, azurelinux3) to 11 OSes for x64, and from 3 OSes to 7 for arm64. Total CI builds increase from ~7 to ~18, potentially slowing PR feedback loops significantly. The linux-valgrind job still explicitly sets os: jammy, suggesting the original limiting pattern was intentional for CI speed.

Fix in Cursor Fix in Web

secrets: inherit
macos:
uses: ./.github/workflows/flow-macos.yml
needs: [prepare-values]
with:
os: jammy rocky9 amazonlinux2 azurelinux3
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
linux-valgrind:
uses: ./.github/workflows/flow-linux-x86.yml
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
os: jammy
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
run_valgrind: true
Expand Down
22 changes: 9 additions & 13 deletions .github/workflows/event-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,24 +28,19 @@ jobs:
- name: set env
id: set-env
run: |
echo "redis-ref=6.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
echo "redis-ref=${{ inputs.redis-ref || '6.2' }}" >> $GITHUB_OUTPUT
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
ubuntu-arm64:
uses: ./.github/workflows/flow-ubuntu-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
alpine:
uses: ./.github/workflows/flow-alpine.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
macos:
Expand All @@ -55,9 +50,10 @@ jobs:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
linux-valgrind:
uses: ./.github/workflows/flow-linux-x86.yml
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
os: jammy
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
run_valgrind: true
Expand Down
18 changes: 7 additions & 11 deletions .github/workflows/event-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,19 @@ jobs:
id: set-env
run: |
echo "redis-ref=6.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3 amazonlinux2023 alpine
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
ubuntu-arm64:
uses: ./.github/workflows/flow-ubuntu-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
alpine:
uses: ./.github/workflows/flow-alpine.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
macos:
Expand Down
113 changes: 0 additions & 113 deletions .github/workflows/flow-alpine.yml
View file
Open in desktop

This file was deleted.

Loading
Loading