Skip to content

MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-… #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AvivDavid23 merged 2 commits into from
Feb 9, 2026
Merged

MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-… #1502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df06a57
MOD-13779 | MOD-13574 | MOD-13811 Dockerize CI, add AL2023 and macos-…
AvivDavid23 Feb 6, 2026
a70d4bc
use old setuptools
AvivDavid23 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/event-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,31 @@ jobs:
id: set-env
run: |
echo "redis-ref=7.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
os: jammy rocky9 amazonlinux2 azurelinux3
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
azurelinux3-arm64:
uses: ./.github/workflows/flow-azurelinux3-arm.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
Copy link

@cursor cursor bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI builds all platforms without OS restriction

Medium Severity

Neither build-linux-x64 nor build-linux-arm64 specifies an os parameter, so flow-linux.yml falls back to all default platforms (11 x64 + 7 arm64 = 18 builds). The old CI workflow was restricted to just jammy rocky9 amazonlinux2 azurelinux3 for x64 and only azurelinux3 for arm64. This ~3.6x increase in matrix jobs runs on every pull request, significantly increasing CI resource consumption and feedback time.

Fix in Cursor Fix in Web

macos:
uses: ./.github/workflows/flow-macos.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
linux-valgrind:
uses: ./.github/workflows/flow-linux-x86.yml
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
os: jammy
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
run_valgrind: true
Expand Down
28 changes: 9 additions & 19 deletions .github/workflows/event-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,30 +28,19 @@ jobs:
- name: set env
id: set-env
run: |
echo "redis-ref=7.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
echo "redis-ref=${{ inputs.redis-ref || '7.2' }}" >> $GITHUB_OUTPUT
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
ubuntu-arm64:
uses: ./.github/workflows/flow-linux-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
azurelinux3-arm64:
uses: ./.github/workflows/flow-azurelinux3-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
alpine:
uses: ./.github/workflows/flow-alpine.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
macos:
Expand All @@ -61,9 +50,10 @@ jobs:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
linux-valgrind:
uses: ./.github/workflows/flow-linux-x86.yml
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
os: jammy
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
run_valgrind: true
Expand Down
24 changes: 7 additions & 17 deletions .github/workflows/event-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,29 +25,19 @@ jobs:
id: set-env
run: |
echo "redis-ref=7.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3 amazonlinux2023 alpine
arch: x64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
ubuntu-arm64:
uses: ./.github/workflows/flow-linux-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
azurelinux3-arm64:
uses: ./.github/workflows/flow-azurelinux3-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
alpine:
uses: ./.github/workflows/flow-alpine.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
macos:
Expand Down
28 changes: 10 additions & 18 deletions .github/workflows/event-weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,30 +24,21 @@ jobs:
id: set-env
run: |
echo "redis-ref=7.2" >> $GITHUB_OUTPUT # todo change per version/tag
linux:
uses: ./.github/workflows/flow-linux-x86.yml
build-linux-x64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
# os: jammy rocky9 amazonlinux2
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3
os: bionic focal jammy rocky8 rocky9 bullseye amazonlinux2 mariner2 azurelinux3 alpine
Copy link

@cursor cursor bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weekly workflow missing amazonlinux2023 in OS lists

Low Severity

The amazonlinux2023 platform is missing from the weekly workflow's explicit os lists for both x64 and arm64. It's present in the flow-linux.yml defaults (used by CI/nightly) and in the event-tag.yml x64 list, so this appears to be an oversight given the PR's goal of adding AL2023 support.

Additional Locations (1)

Fix in Cursor Fix in Web

redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
ubuntu-arm64:
uses: ./.github/workflows/flow-linux-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
azurelinux3-arm64:
uses: ./.github/workflows/flow-azurelinux3-arm.yml
needs: [prepare-values]
with:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
alpine:
uses: ./.github/workflows/flow-alpine.yml
build-linux-arm64:
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: arm64
os: bionic focal jammy rocky9 azurelinux3 alpine
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
macos:
Expand All @@ -57,9 +48,10 @@ jobs:
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
secrets: inherit
linux-valgrind:
uses: ./.github/workflows/flow-linux-x86.yml
uses: ./.github/workflows/flow-linux.yml
needs: [prepare-values]
with:
arch: x64
os: jammy
redis-ref: ${{needs.prepare-values.outputs.redis-ref}}
run_valgrind: true
Expand Down
113 changes: 0 additions & 113 deletions .github/workflows/flow-alpine.yml
View file
Open in desktop

This file was deleted.

Loading
Loading