MOD-13014 Remove user info from errors (#1474) #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| message: final_msg, | ||
| }) | ||
| let message = format!("Error at position {}: {}", location, msg); | ||
| Err(QueryCompilationError { location, message }) |
There was a problem hiding this comment.
Duplicate position information in query compilation error messages
Medium Severity
The error message contains duplicated position information. Line 177 constructs message as "Error at position {location}: {msg}", but the Display impl (lines 113-120) also prepends "Error occurred at position {location}, ". This produces output like "Error occurred at position 5, Error at position 5: expected one of..." where the position appears twice.
Additional Locations (1)
gabsow
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path info
value types
query compilation error
query compilation error
cleaning up
stop using Error when we have RedisError
Note
Unifies error handling and messaging across the JSON module and json_path.
ErrorwithRedisError/RedisResultthroughout (commands,manager,ivalue_manager,key_value,backward); removeredis_json/src/error.rserr_invalid_path,err_invalid_path_or,err_json; simplify error text (no path/value echoes); adjust tests accordinglyQueryCompilationErrortoRedisErrorand improve messages; minor wording fixes in json_pathRedisResult; small refactors for RESP2/RESP3 repliesredis-moduledep tojson_path; standardize importsredis_jsonto2.8.17and refresh dependenciesWritten by Cursor Bugbot for commit 911f4b2. This will update automatically on new commits. Configure here.