Skip to content

Conversation

@AvivDavid23
Copy link
Contributor

@AvivDavid23 AvivDavid23 commented Jan 21, 2026

  • path info

  • value types

  • query compilation error

  • query compilation error

  • cleaning up

  • stop using Error when we have RedisError


Note

Modernizes error handling and aligns APIs while updating dependencies.

  • Remove redis_json::error::Error; switch all functions to return RedisResult/RedisError and introduce unified helpers (err_invalid_path, err_invalid_path_or, err_json)
  • Sanitize error outputs (drop path/value specifics); adjust JSONPath compile errors; add From<QueryCompilationError> -> RedisError
  • Update command and manager implementations to new signatures; simplify legacy vs. RESP3 handling; minor wording/typo fixes
  • Bump redis_json to 8.2.9; update redismodule-rs to v2.1.3 (adds common); add redis-module to json_path; pin serde_json <1.0.147
  • Tests updated to match new, less-detailed error messages

Written by Cursor Bugbot for commit b793543. This will update automatically on new commits. Configure here.

* path info

* value types

* query compilation error

* query compilation error

* cleaning up

* stop using Error when we have RedisError
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (c9d32b5) to head (b793543).
⚠️ Report is 11 commits behind head on 8.2.

Files with missing lines Patch % Lines
json_path/src/json_path.rs 73.68% 5 Missing ⚠️
redis_json/src/ivalue_manager.rs 78.26% 5 Missing ⚠️
redis_json/src/backward.rs 25.00% 3 Missing ⚠️
redis_json/src/key_value.rs 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.2    #1488      +/-   ##
==========================================
- Coverage   79.20%   78.68%   -0.52%     
==========================================
  Files          15       14       -1     
  Lines        3707     3547     -160     
==========================================
- Hits         2936     2791     -145     
+ Misses        771      756      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@AvivDavid23 AvivDavid23 merged commit 808e61b into 8.2 Jan 21, 2026
21 checks passed
@AvivDavid23 AvivDavid23 deleted the 8.2_cp_logs branch January 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants