MOD-13014 Remove user info from errors (#1474) #1480
Conversation
* path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| message: final_msg, | ||
| }) | ||
| let message = format!("Error at position {}: {}", location, msg); | ||
| Err(QueryCompilationError { location, message }) |
There was a problem hiding this comment.
Duplicate position info in compilation error messages
The error message field is now constructed with "Error at position {}: {}" format, but the Display implementation for QueryCompilationError also prefixes the message with "Error occurred at position {}, {}". When to_string() is called (via the From<QueryCompilationError> for RedisError implementation), the resulting error message will contain duplicate position information, such as: "Error occurred at position 5, Error at position 5: expected one of...". The message field should contain only the parsing error details without the position prefix.
Additional Locations (1)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #1480 +/- ##
==========================================
- Coverage 77.56% 76.97% -0.60%
==========================================
Files 16 15 -1
Lines 3945 3756 -189
==========================================
- Hits 3060 2891 -169
+ Misses 885 865 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
path info
value types
query compilation error
query compilation error
cleaning up
stop using Error when we have RedisError
Note
Unifies error handling and sanitizes error output while modernizing deps.
redis_json/src/error.rs; switch all command/manager/key code toRedisError/RedisResultand simplify signatureserr_invalid_path,err_invalid_path_or,err_json; scrub detailed path/type from messages; update tests to matchQueryCompilationErrortoRedisErrorand refine compilation error text injson_path; minor wording fixesredis-moduletojson_path; bumpredismodule-rstov2.1.3via workspace and use workspace deps inredis_jsonJSON.CLEAR)Written by Cursor Bugbot for commit 03b166f. This will update automatically on new commits. Configure here.