MOD-13014 Remove user info from errors #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2025 12:42
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
- Coverage 77.44% 77.22% -0.22%
==========================================
Files 16 15 -1
Lines 4025 3842 -183
==========================================
- Hits 3117 2967 -150
+ Misses 908 875 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ephraimfeldblum
changed the title
ephraimfeldblum
changed the title
| match (p.len(), n.len()) { | ||
| (0, 0) => "parsing error".to_string(), | ||
| (_, 0) => format!("expected one of the following: {p}"), | ||
| (0, _) => format!("unexpected tokens found: {n}"), |
Contributor
There was a problem hiding this comment.
Couldn't n leak sensitive data?
Contributor
Author
There was a problem hiding this comment.
sensitive data? i'm not certain, but i don't think so. it's the result of stringifying a parsing rule.
galcohen-redislabs
approved these changes
Dec 15, 2025
gabsow
pushed a commit
that referenced
this pull request
Dec 28, 2025
* path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError
gabsow
added a commit
that referenced
this pull request
Dec 28, 2025
gabsow
added a commit
that referenced
this pull request
Dec 28, 2025
AvivDavid23
pushed a commit
that referenced
this pull request
Jan 21, 2026
* path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError
AvivDavid23
pushed a commit
that referenced
this pull request
Jan 21, 2026
* path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError
AvivDavid23
added a commit
that referenced
this pull request
Jan 21, 2026
* MOD-13014 Remove user info from errors (#1474) * path info * value types * query compilation error * query compilation error * cleaning up * stop using Error when we have RedisError * fmt * remove file --------- Co-authored-by: efeldblum <109016390+ephraimfeldblum@users.noreply.github.com>
AvivDavid23
added a commit
that referenced
this pull request
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOD-13014