Skip to content

ORDER BY variable validation#2860

Open
raz-mon wants to merge 16 commits into
masterfrom
order-by-aggregation-validations
Open

ORDER BY variable validation#2860
raz-mon wants to merge 16 commits into
masterfrom
order-by-aggregation-validations

Conversation

@raz-mon
Copy link
Copy Markdown
Collaborator

@raz-mon raz-mon commented Feb 1, 2023

Validates that when an aggregation is used in a projection of a WITH\RETURN clause followed by an ORDER-BY clause, then the variables used in the ORDER BY clause are one of the projected variables only (either an aggregation expression or a projection)

doc-fix

fix

added AR_EXP_Equal func

some fixes
@raz-mon raz-mon changed the title added aggregated projections ordering validation ORDER BY variable validation Feb 1, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2023

Codecov Report

❌ Patch coverage is 63.46154% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.76%. Comparing base (538466f) to head (59f55b9).
⚠️ Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
...n_plan/execution_plan_build/build_projection_ops.c 60.86% 27 Missing ⚠️
src/arithmetic/arithmetic_expression.c 68.57% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
- Coverage   90.31%   89.76%   -0.55%     
==========================================
  Files         283      283              
  Lines       28053    28148      +95     
==========================================
- Hits        25337    25268      -69     
- Misses       2716     2880     +164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raz-mon raz-mon requested a review from swilly22 February 13, 2023 10:06
@raz-mon raz-mon requested a review from AviAvni February 22, 2023 08:18
@nafraf nafraf linked an issue Mar 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong validation of ambiguous aggregation expression

3 participants