fixed return string.join([])

Ofir Moskovich · Ofir Moskovich · commit 75787d9158cf · 2023-03-12T14:17:55.000+02:00
diff --git a/src/arithmetic/string_funcs/string_funcs.c b/src/arithmetic/string_funcs/string_funcs.c
@@ -224,6 +224,10 @@ SIValue AR_JOIN(SIValue *argv, int argc, void *private_data) {
 
 	uint32_t count = SIArray_Length(list);
 
+	if(count == 0) {
+		return SI_TransferStringVal("");
+	}
+
 	size_t delimeter_len = strlen(delimiter);
 	uint str_len = delimeter_len * (count - 1);
 	for(uint i = 0; i < count; i++) {
diff --git a/tests/flow/test_function_calls.py b/tests/flow/test_function_calls.py
@@ -2483,6 +2483,11 @@ def test89_JOIN(self):
         query = """RETURN string.join(['HELL','OW', 'NOW'], ' ')"""
         actual_result = graph.query(query)
         self.env.assertEquals(actual_result.result_set[0], expected_result)
+
+        expected_result = ['']
+        query = """RETURN string.join([])"""
+        actual_result = graph.query(query)
+        self.env.assertEquals(actual_result.result_set[0], expected_result)
   
     def test90_size(self):
         query_to_expected_result = {
