Improve handling of 'final' in class declaration (danmar#4706)

chrchr-github · web-flow · commit 9cf934c10d4a · 2023-01-18T17:08:43.000+01:00
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -8485,6 +8485,10 @@ void Tokenizer::simplifyKeyword()
             // 1) struct name final { };   <- struct is final
             if (Token::Match(tok->previous(), "struct|class|union %type%")) {
                 Token* finalTok = tok->next();
+                if (tok->isUpperCaseName() && Token::Match(finalTok, "%type%") && finalTok->str() != "final") {
+                    tok = finalTok;
+                    finalTok = finalTok->next();
+                }
                 if (Token::simpleMatch(finalTok, "<")) { // specialization
                     finalTok = finalTok->findClosingBracket();
                     if (finalTok)
diff --git a/test/testtokenize.cpp b/test/testtokenize.cpp
@@ -2573,6 +2573,8 @@ class TestTokenizer : public TestFixture {
             ASSERT_EQUALS("static void * thread_local_var ; "
                           "void * thread_local_var_2 ;", tokenizeAndStringify(code));
         }
+
+        ASSERT_EQUALS("class Fred { } ;", tokenizeAndStringify("class DLLEXPORT Fred final { };"));
     }
 
     void implicitIntConst() {
@@ -6647,7 +6649,7 @@ class TestTokenizer : public TestFixture {
     void removeMacroInClassDef() { // #6058
         ASSERT_EQUALS("class Fred { } ;", tokenizeAndStringify("class DLLEXPORT Fred { } ;"));
         ASSERT_EQUALS("class Fred : Base { } ;", tokenizeAndStringify("class Fred FINAL : Base { } ;"));
-        ASSERT_EQUALS("class Fred final : Base { } ;", tokenizeAndStringify("class DLLEXPORT Fred final : Base { } ;")); // #11422
+        ASSERT_EQUALS("class Fred : Base { } ;", tokenizeAndStringify("class DLLEXPORT Fred final : Base { } ;")); // #11422
         // Regression for C code:
         ASSERT_EQUALS("struct Fred { } ;", tokenizeAndStringify("struct DLLEXPORT Fred { } ;", true, Settings::Native, "test.c"));
     }

Original file line number	Diff line number	Diff line change
`@@ -2573,6 +2573,8 @@ class TestTokenizer : public TestFixture {`
`2573`	`2573`	`ASSERT_EQUALS("static void * thread_local_var ; "`
`2574`	`2574`	`"void * thread_local_var_2 ;", tokenizeAndStringify(code));`
`2575`	`2575`	`}`
	`2576`	`+`
	`2577`	`+ ASSERT_EQUALS("class Fred { } ;", tokenizeAndStringify("class DLLEXPORT Fred final { };"));`
`2576`	`2578`	`}`
`2577`	`2579`
`2578`	`2580`	`void implicitIntConst() {`
`@@ -6647,7 +6649,7 @@ class TestTokenizer : public TestFixture {`
`6647`	`6649`	`void removeMacroInClassDef() { // #6058`
`6648`	`6650`	`ASSERT_EQUALS("class Fred { } ;", tokenizeAndStringify("class DLLEXPORT Fred { } ;"));`
`6649`	`6651`	`ASSERT_EQUALS("class Fred : Base { } ;", tokenizeAndStringify("class Fred FINAL : Base { } ;"));`
`6650`		`- ASSERT_EQUALS("class Fred final : Base { } ;", tokenizeAndStringify("class DLLEXPORT Fred final : Base { } ;")); // #11422`
	`6652`	`+ ASSERT_EQUALS("class Fred : Base { } ;", tokenizeAndStringify("class DLLEXPORT Fred final : Base { } ;")); // #11422`
`6651`	`6653`	`// Regression for C code:`
`6652`	`6654`	`ASSERT_EQUALS("struct Fred { } ;", tokenizeAndStringify("struct DLLEXPORT Fred { } ;", true, Settings::Native, "test.c"));`
`6653`	`6655`	`}`