valgrind.yml: actually fail the workflow when an error is detected (danmar#4716)

firewave · web-flow · commit 7876e1064f3f · 2023-01-18T17:01:26.000+01:00
diff --git a/.github/workflows/valgrind.yml b/.github/workflows/valgrind.yml
@@ -40,12 +40,15 @@ jobs:
 
       - name: Run valgrind
         run: |
-          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate 9>memcheck.log
+          ec=0
+          valgrind --error-limit=yes --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --suppressions=valgrind/testrunner.supp --gen-suppressions=all --log-fd=9 --error-exitcode=42 ./testrunner TestGarbage TestOther TestSimplifyTemplate 9>memcheck.log || ec=1
           cat memcheck.log
+          exit $ec
         env:
           DEBUGINFOD_URLS: https://debuginfod.ubuntu.com
           
       - uses: actions/upload-artifact@v3
+        if: success() || failure()
         with:
           name: Logs
           path: ./*.log
