Cleaning up some build warnings.#2
Merged
Merged
Conversation
made the version concrete.
abersnaze
added a commit
that referenced
this pull request
Dec 2, 2014
Cleaning up some build warnings.
Contributor
|
BTW, versions do not have to be concrete for ReactiveX projects. They can use dependency locking if they want a predictable version. |
Contributor
Author
|
@benjchristensen said that maven central couldn't handle dependencies with a plus in them. |
Contributor
|
Sorta. You are correct that Central can't handle Gradle dynamic ranges (and shouldn't have any dynamic versions at all). BUT, the nebula-publishing-plugin takes care of this for you, and will publish only the resolved version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added license to the source.
made the version concrete.