Repository navigation
Observable direct rest - #4145
Merged
Merged
Conversation
Current coverage is 69.27%@@ 2.x #4145 diff @@
==========================================
Files 386 387 +1
Lines 27277 27333 +56
Methods 0 0
Messages 0 0
Branches 4410 4410
==========================================
+ Hits 18888 18935 +47
+ Misses 6502 6501 -1
- Partials 1887 1897 +10
|
Member
Author
|
@JakeWharton do you want to review this? |
| * <p>Allows discovering the chain of observables. | ||
| * @return the source ObservableConsumable | ||
| */ | ||
| public final ObservableConsumable<T> source() { |
Contributor
There was a problem hiding this comment.
This looks unused. Subclasses can just use the source field directly.
Member
Author
There was a problem hiding this comment.
It wasn't meant for them but the upcoming debug support.
Contributor
|
lgtm 👍 |
Member
Author
|
Thanks @JakeWharton ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This concludes the architecture switch for 2.x.