Skip to content

Observable direct rest - #4145

Merged
akarnokd merged 2 commits into
ReactiveX:2.xfrom
akarnokd:ObservableDirectRest
Jun 29, 2016
Merged

akarnokd merged 2 commits into
ReactiveX:2.xfrom
akarnokd:ObservableDirectRest

Conversation

@akarnokd

Copy link
Copy Markdown
Member

This concludes the architecture switch for 2.x.

@akarnokd akarnokd added this to the 2.0 RC 1 milestone Jun 29, 2016
@codecov-io

Copy link
Copy Markdown

Current coverage is 69.27%

Merging #4145 into 2.x will increase coverage by 0.03%

@@                2.x      #4145   diff @@
==========================================
  Files           386        387     +1   
  Lines         27277      27333    +56   
  Methods           0          0          
  Messages          0          0          
  Branches       4410       4410          
==========================================
+ Hits          18888      18935    +47   
+ Misses         6502       6501     -1   
- Partials       1887       1897    +10   

Powered by Codecov. Last updated by a09f5a4...2ddb055

@akarnokd

Copy link
Copy Markdown
Member Author

@JakeWharton do you want to review this?

* <p>Allows discovering the chain of observables.
* @return the source ObservableConsumable
*/
public final ObservableConsumable<T> source() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks unused. Subclasses can just use the source field directly.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't meant for them but the upcoming debug support.

@JakeWharton

Copy link
Copy Markdown
Contributor

lgtm 👍

@akarnokd

Copy link
Copy Markdown
Member Author

Thanks @JakeWharton !

@akarnokd
akarnokd merged commit d4f041b into ReactiveX:2.x Jun 29, 2016
@akarnokd
akarnokd deleted the ObservableDirectRest branch June 29, 2016 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants