Allow loading of uncompressed rcnet file to allow version control tools to work nicely w/ ReClass.NET files#227
Closed
dschu012 wants to merge 3 commits intoReClassNET:masterfrom
Closed
Conversation
…ls to work nicely w/ ReClass.NET files
KN4CK3R
reviewed
Jun 8, 2022
KN4CK3R
reviewed
Jun 8, 2022
| @@ -1,9 +1,11 @@ | |||
| namespace ReClassNET.DataExchange.ReClass | |||
| namespace ReClassNET.DataExchange.ReClass | |||
Member
There was a problem hiding this comment.
What are these changes here and in ReClass.NET_Launcher/Program.cs? BOM or something?
Author
There was a problem hiding this comment.
It seems so? Idk why those got added. I tried to revert them and vscode wasn't showing those lines as changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on rcnet files w/ multiple people, right now it is impossible to see changes from version to version since they are a zip archive. This PR is an attempt at allowing a
rcnetxmlto be Saved/Loaded with the raw XML to allow version tracking tools like git to work nicely w/ the files.