Conversation
eddelbuettel
approved these changes
Mar 29, 2026
Member
eddelbuettel
left a comment
eddelbuettel
left a comment
There was a problem hiding this comment.
Looks good to me. It will get in the queue of reverse depends runs to do.
| if (identity == R_UnboundValue) { | ||
| stop("Failed to find 'base::identity()'"); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Just for kicks: when/why did we need this? When could that have been true?
Member
Author
There was a problem hiding this comment.
git-blame says that this is from 20 years ago, and Rcpp is 18 years old, so... never.
Member
There was a problem hiding this comment.
No, it says @kevinushey did this in 2015:
454de74f5 (Kevin Ushey 2015-07-13 17:45:01 -0700 59) if (identity == R_UnboundValue) {
454de74f5 (Kevin Ushey 2015-07-13 17:45:01 -0700 60) stop("Failed to find 'base::identity()'");
1c90562c8 (Kevin Ushey 2015-07-13 15:43:09 -0700 61) }
(i.e. I was asking why we added this / why we can now simply remove it).
| #else | ||
| SEXP env = environment(); | ||
| R_BindingType_t bt = R_GetBindingType(Storage::get__(), env); | ||
| return bt != R_BindingTypeUnbound; |
| } | ||
| return res ; | ||
| Symbol nameSym = Rf_install(name.c_str()); | ||
| return get(nameSym); |
Member
There was a problem hiding this comment.
That simplification seems almost too good to be true. Why did we not do that earlier? 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1465.
For promises, we have here a temporary workaround, but this is going to come back at us, because we are using a bunch of functions (
PRVALUE,PRENV...) that are not part of the API, even if we don't see a NOTE yet. The problem is that I don't see alternatives yet.Checklist
R CMD checkstill passes all tests