Patch 1 - modernize #337
Patch 1 - modernize #337
Conversation
Modernize all sqli function calls.
Add connection parameter as a function argument where necessary.
Misc other updates and fixes.
Now suppots mariadb since sqlite is depreciated.
Made several changes to index.php
-- Updated calorie and carb calculations
-- Removed gravity and balance from the display. Only beer snobs
really give a shit about this, so add it back in if you like.
Known bugs:
There are still some problems with the installer related to database
access and configuration that I haven't looked at yet.
Tap management is really wonky. The form does not autopopulate the
values for the beer slected from the drop down. You have to manually
re-enter them for it to work. The form will submit and put your keg
into 'serving' state but not show on your tap list.
I haven't tested anything related to the flow meters, so I'm not sure if
any of that still works. Would appreciate a tester here in the meantime
as I do not have flow meters installed in my setup (yet).
|
I would love to get this at least working properly on a modern stack so people can still use it. I have had no time to manage any of these PRs but have a little now and want to make it useable. There is another PR that seems to work well but has added A LOT to the app. If you can get the bugs you added to your readme worked out I will gladly QA it and give your PR a code read so we can get this merged into master and release a new version that at least works. |
|
First, I can't believe this is still going. Second, how close is this to being useable on a Pi 4? I was one of the original testers / guinea pigs once it (quickly) out-paced my coding capabilities. |
|
With the patches on my repo it should work. Been busy the past few weeks setting up my HERMS system, so I haven't finished everything yet (note the known issues), nor have I run the full install. There's probably some bugs there with the database change from mysql to mariadb. ¯_(ツ)_/¯ |
Add fixes for calorie count in alternate display section. Fixes for mysqli.
|
I don't really know how to use Git so I haven't added changes here, but I have got it working on a Raspberry Pi 4 as the webserver, however I am using an ESP8266 to monitor the flow meters and wirelessly send the updates to the web server on the RPi4. I left all the serial code in place so it should still work too. I made a stream of conscienceness blog post: |
|
@dfish6101 - No problem, thanks for the information. I'll check it out when I get a chance in the next couple weeks. Just been really busy lately and haven't had much time to touch this project and finish all the updates. |
4 participants
This fixes all of the database connection problems with the modern LAMP stack using mysqli instead of mysql. The index.php changes are subjective, feel free to toss those out. See the notes, it's not perfect in terms or tap management - I haven't looked into that issue yet nor have I tested anything related to the flow meters.
-Cheers