Highlight user space == ROCm and kernel space == amdgpu #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses #648.
We're not clear enough in the below page that user space == ROCm version.
https://rocm.docs.amd.com/projects/install-on-linux/en/latest/reference/user-kernel-space-compat-matrix.html
Technical Details
Adding in a note to highlight ROCm == user space, amdgpu == kernel space. Removed the extra references to
(amdgpu)as they're redundant with this heading.It also might make sense to reference the existing blog post on this though I'm not sure if the terminology and information is up to date.
The title of this page also isn't very clear - maybe we should stick with "ROCm Toolkit" from the blog post.
User and AMD GPU DrivervsROCm Toolkit and amdgpu driver. The latter is straight forward, we can delve into the user mode and kernel mode specifics once they land on the page.Submission Checklist