Skip to content

Test Permission CRUD #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmartinol merged 2 commits into from
Jul 30, 2024
Merged

Test Permission CRUD #56

dmartinol merged 2 commits into from
Jul 30, 2024

Conversation

@dmartinol
Copy link

@dmartinol dmartinol commented Jul 30, 2024

  • In test_universal_registry
  • Also fixed a bug in GetPermission method of RegistryServer

dmartinol added 2 commits July 30, 2024 12:52
@dmartinol
Fixed bug in GetPermission API
f529fb5 
Signed-off-by: Daniele Martinoli <86618610+dmartinol@users.noreply.github.com>
@dmartinol
Permission CRUD test
ee3ed14 
Signed-off-by: Daniele Martinoli <86618610+dmartinol@users.noreply.github.com>
@dmartinol
Copy link
Author

dmartinol commented Jul 30, 2024 •
edited
Loading

Note: one of the ITs fails while waiting for this PR to be merged: feast-dev#4328

redhatHameed
redhatHameed approved these changes Jul 30, 2024
View reviewed changes
Copy link

@redhatHameed redhatHameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dmartinol dmartinol merged commit 8bd11a7 into RHEcosystemAppEng:feast-rbac Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@redhatHameed redhatHameed redhatHameed approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmartinol @redhatHameed