Skip to content

Conversation

@renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Oct 24, 2021

What problem did you solve?

R info is provided on attach and is shown in the status bar item text and tooltip.

(If you have)Screenshot

Kapture.2021-10-24.at.22.29.31.mp4

(If you do not have screenshot) How can I check this pull request?

Start an R session and see if the status bar item text and tooltip contains the session information.

@renkun-ken renkun-ken requested a review from ElianHugh October 25, 2021 15:51
@ElianHugh
Copy link
Collaborator

Thanks for this, looks very neat! I'll have a look shortly :)

Copy link
Collaborator

@ElianHugh ElianHugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed an update to shareSession.ts, so that guests get a similar experience:

image

I tested the PR on Arch on R 4.1.1, and everything works nicely! Thanks!

@renkun-ken
Copy link
Member Author

I pushed an update to shareSession.ts, so that guests get a similar experience:

Thanks but I don't see a push to this PR branch?

@ElianHugh
Copy link
Collaborator

Ah - looks like it's not letting me push anything to the branch.

For the moment, I've added the changes to a pastebin here

@renkun-ken renkun-ken merged commit 28bb068 into master Oct 26, 2021
@renkun-ken
Copy link
Member Author

Not sure why you cannot push to the branch. Will take a look later.

@ManuelHentschel ManuelHentschel deleted the r-info branch November 27, 2021 13:03
ElianHugh pushed a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
* Add R info to status bar item text and tooltip

* Remove attach_time and add command

* Update shareSession.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants