Skip to content

numeric_version() with character arg#1523

Merged
renkun-ken merged 1 commit into
REditorSupport:masterfrom
pawelru:master
May 6, 2024
Merged

numeric_version() with character arg#1523
renkun-ken merged 1 commit into
REditorSupport:masterfrom
pawelru:master

Conversation

@pawelru

@pawelru pawelru commented May 6, 2024

Copy link
Copy Markdown
Contributor

a follow-up on #1520

There is one more occurrence where this function is called on numeric. On R 4.4.0 it is failing

r$> numeric_version(0)
Error in .make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version) : 
  invalid non-character version specification 'x' (type: double)

renkun-ken
renkun-ken approved these changes May 6, 2024
View reviewed changes

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit bc47b97 into REditorSupport:master May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renkun-ken renkun-ken renkun-ken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pawelru @renkun-ken