Explicit workspace behaviour #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always show workspace viewer - Fallback message when session watcher is disabled - Don't error when calling view without an active workspace viewer
don't register the tree data provider unless session watcher enabled
Hide view buttons when session viewer is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
It can be confusing for users when the workspace viewer doesn't show up, especially when there is no message explicitly stating why it isn't appearing. This PR ensures that users are pointed in the right direction.
Screenshot
How can I check this pull request?
Disable session watcher & reload --> should be greeted by welcome text