Fixes handling of applications without packages in resources#66
Open
kiber-io wants to merge 1 commit intoREAndroid:mainfrom
Open
Fixes handling of applications without packages in resources#66kiber-io wants to merge 1 commit intoREAndroid:mainfrom
kiber-io wants to merge 1 commit intoREAndroid:mainfrom
Conversation
REAndroid
reviewed
Jun 20, 2024
| packageBlock = tableBlock.pickOrEmptyPackage(); | ||
| } | ||
| if(packageBlock != null) { | ||
| manifestBlock.setPackageBlock(packageBlock); |
Owner
There was a problem hiding this comment.
Thank you,
there are some cases where packages will be constructed latter, can you experiment with this one ?
put setApkFile out of if block
if(packageBlock != null) {
manifestBlock.setPackageBlock(packageBlock);
}
manifestBlock.setApkFile(this);
Owner
There was a problem hiding this comment.
Hmm ...
The purpose of ensureLoadedManifestLinked() is to check multiple times that manifest has correct package. In both cases ( pickOneOrEmpty & setApkFile) the manifest will claim having correct package even if new package is produced latter.
My other idea is :
if(packageBlock != null && !packageBlock.isEmpty()) {
TableBlock linkedTable = packageBlock.getTableBlock();
if(linkedTable == tableBlock) {
return;
}
}
packageBlock = tableBlock.pickOne(manifestBlock.guessCurrentPackageId());
if(packageBlock == null) {
packageBlock = tableBlock.pickOrEmptyPackage();
}
REAndroid
added a commit
that referenced
this pull request
Aug 2, 2024
REAndroid
added a commit
that referenced
this pull request
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After one of the latest changes the handling of applications that don't contain packages in the .arsc file broke down:
And on build: