Support watchOS - #1154
Draft
JosephDuffy wants to merge 10 commits into
Draft
Conversation
My fork of Nimble is required to build via Xcode
The watchOS support PR (Quick/Nimble#916) has been merged.
|
Hey @JosephDuffy, thanks for doing this! Looks like this is still a draft for a reason… 😅 Is this doable or is there some major blocker? |
# Conflicts: # Package.swift # Quick.podspec # Tests/QuickTests/QuickTests/FunctionalTests/QuickSpec_SelectedTests.swift
Author
|
@MikeChugunov I just merged in the latest changes, I think this is good to go :) |
|
Hey @younata! I know you done some work on making watchOS support happen for Nimble. Can you please look into this one too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a counterpart to Quick/Nimble#916, which added support for watchOS to Nimble.
Note that this is a draft until a new version of Nimble is released with watchOS support. Until then this points at
main.I'm also not sure if the tests will run on CI correctly because the tests require watchOS 7.4 to run and I'm not sure what version of watchOS the simulators are configured with.
I also found that the tests weren't compiling (using Xcode 13.2.1) so I've updated these too.