Add PageNumber by Section methods in PageContext and Dynamic#482
Open
simusr2 wants to merge 2 commits intoQuestPDF:mainfrom
Open
Add PageNumber by Section methods in PageContext and Dynamic#482simusr2 wants to merge 2 commits intoQuestPDF:mainfrom
simusr2 wants to merge 2 commits intoQuestPDF:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to do checks based on page number in the section context writing Dynamic components.
In particular i need to check, in a Dynamic component placed in the body of the page, if the current page is the first or the last one of current section.
To avoid duplication of logic I created PageNumber by section methods in PageContext and then called them from TextExtensions (already existing methods) and in Dynamic (new methods).
This PR satisfies #469 discussion.