fixed crash due to unnecessary decref of a borrowed reference in params array handling (pythonnet#1163)

lostmsu · AlexCatarino · commit 8126db628a87 · 2020-06-30T00:34:49.000+01:00
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -412,7 +412,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth
         static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out bool isNewReference)
         {
             isNewReference = false;
-            IntPtr op;
+            IntPtr op;
             // for a params method, we may have a sequence or single/multiple items
             // here we look to see if the item at the paramIndex is there or not
             // and then if it is a sequence itself.
@@ -430,10 +430,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out
                 {
                     isNewReference = true;
                     op = Runtime.PyTuple_GetSlice(args, arrayStart, pyArgCount);
-                    if (item != IntPtr.Zero)
-                    {
-                        Runtime.XDecref(item);
-                    }
                 }
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -412,7 +412,7 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`412`	`412`	`static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out bool isNewReference)`
`413`	`413`	`{`
`414`	`414`	`isNewReference = false;`
`415`		`- IntPtr op;`
	`415`	`+ IntPtr op;`
`416`	`416`	`// for a params method, we may have a sequence or single/multiple items`
`417`	`417`	`// here we look to see if the item at the paramIndex is there or not`
`418`	`418`	`// and then if it is a sequence itself.`
`@@ -430,10 +430,6 @@ static IntPtr HandleParamsArray(IntPtr args, int arrayStart, int pyArgCount, out`
`430`	`430`	`{`
`431`	`431`	`isNewReference = true;`
`432`	`432`	`op = Runtime.PyTuple_GetSlice(args, arrayStart, pyArgCount);`
`433`		`- if (item != IntPtr.Zero)`
`434`		`- {`
`435`		`- Runtime.XDecref(item);`
`436`		`- }`
`437`	`433`	`}`
`438`	`434`	`}`
`439`	`435`	`else`