-
Notifications
You must be signed in to change notification settings - Fork 110
Build Python package for PyPI #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Python package for PyPI #117
Conversation
50b33b2 to
119e189
Compare
cool-RR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I'm not a fan of the wordy BDD, but I respect your choice.
Drop Python 2 from linting and tests
119e189 to
043fe4b
Compare
|
I see that tests are passing. Ready to merge? |
|
As long as the title has the "WIP:" prefix you should consider it "work in progress", hence not ready to merge. I'll change the title as soon as it's ready to merge. What is missing is the build and upload logic to PyPI in the Travis configuration. You'll have to help me with submitting credentials to your Travis account (because builds happen on your Travis account), later. |
|
Cool. I'm not sure whether GitHub notifies on name changes, so make a
comment when you do.
…On Sun, Sep 30, 2018, 15:35 Peter Bittner ***@***.***> wrote:
As long as the title has the "WIP:" prefix you should consider it "work in
progress", hence not ready to merge. I'll change the title as soon as it's
ready to merge.
What is missing is the build and upload logic to PyPI in the Travis
configuration <https://docs.travis-ci.com/user/deployment/pypi/>. You'll
have to help me with submitting credentials to your Travis account (because
builds happen on your Travis account), later.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADdyrP9MpygKR4IHwnfP71rixU1vA9dks5ugLp4gaJpZM4XA8AM>
.
|
We can use pytest instead, technically it doesn't make a difference. (In fact, I first started to prepare a pytest setup.) The reason I chose behave is that Gherkin is much more self-explanatory (in the build log output), even for users and developers not practical with writing tests. I feel that is closer to the audience of PythonTurtle. Just in case someone may be interested in taking a look at the technical setup of the project. |
|
My preference is pytest. If you strongly prefer bdd, free to stay with that.
…On Sun, Sep 30, 2018, 15:44 Peter Bittner ***@***.***> wrote:
I'm not a fan of the wordy BDD, but I respect your choice.
We can use pytest <https://docs.pytest.org/en/latest/> instead,
technically it doesn't make a difference. (In fact, I first started to
prepare a pytest setup.)
The reason I chose behave <https://behave.readthedocs.io/en/latest/> is
that Gherkin is much more self-explanatory (in the build log output), even
for users and developers not practical with writing tests. I feel that also
closer to the audience of PythonTurtle. Just in case someone may be
interesting in looking into the project closer.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADdynYLLaxQuGyEDhj3o84gOv-4IH2Yks5ugLzGgaJpZM4XA8AM>
.
|
Silence too loud (typically less critical) complaints for now
Let's change that later. I don't insist, but I'd better get the deployment working first. |
|
It looks like you really have to generate an encrypted password using the
The docs say, If you don't want or can't install the Ruby gem you can try the following command using Docker (which works on my machine): $ docker run --rm -v $PWD:/repo -v ~/.travis:/travis antonmry/travis-docker encrypt "foo-bar-baz-123" --add publish.password
Outdated CLI version, run `gem install travis`.
detected repository as bittner/PythonTurtleI've left the command output there, so you can spot why my Travis account is not sufficient: It's adding the key to the "wrong" project. |
|
Oh, make it You need to run this from the project repository, having the project cloned on your computer. It will modify the pypi:
password:
secure: I/UBNQygyE....YxwwP4g=I only need the content of the |
|
Hmmm, the more I think about it ... I guess it has to be |
| provider: pypi | ||
| user: coolRR | ||
| password: | ||
| secure: <travis-encrypt-value-here> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, the PR is now ready to merge. We'll only need to update this password value later (to make uploading to PyPI work).
|
Here's the line: |
This PR introduces a number of additions and changes that make building and deploying a Python package easier and cleaner:
setuptools) instead of directly from file system