Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
==========================================
- Coverage 84.97% 84.53% -0.44%
==========================================
Files 107 113 +6
Lines 22249 22883 +634
==========================================
+ Hits 18906 19345 +439
- Misses 3343 3538 +195 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
This PR aims at implementing the solver for 1D UOT with Frank-Wolfe (Faster Unbalanced Optimal Transport: Translation invariant Sinkhorn and 1-D Frank-Wolfe), as well as the Sliced Unbalanced OT and Unbalanced sliced OT distances (Slicing Unbalanced Optimal Transport).
Changes:
ot.solver_1d.emd_1d_dualfunction to compute the dual potentials in 1D efficiently (still some bugs)ot.solver_1d.emd_1d_dual_backpropfunction, which computes the dual potentials in 1D by using backpropagation over the 1D wasserstein distance (in pytorch and jax).ot.unbalanced._solver_1d.uot_1dto compute the 1D UOT problems with Frank-Wolfeot.unbalanced._sliced.sliced_unbalanced_otto compute SUOTot.unbalanced._sliced.unbalanced_sliced_otto compute USOTot.lp.solver_circle.pyMotivation and context / Related issue
These functions allow to compute unbalanced OT problems efficiently.
How has this been tested (if it applies)
It still needs to be properly tested.
PR checklist