Skip to content

Fix bug where dummy_thread was always imported - #124

Merged
edschofield merged 1 commit into
PythonCharmers:masterfrom
melund:master
Dec 14, 2014
Merged

edschofield merged 1 commit into
PythonCharmers:masterfrom
melund:master

Conversation

@melund

@melund melund commented Dec 3, 2014

Copy link
Copy Markdown
Contributor

The code always import the dummy_thread module even on platforms where the real thread module is available. This caused bugs in other packages try to import _thread in pyhton 2.

try:
from _thread import interrupt_main # Py 3
except ImportError:
from thread import interrupt_main # Py 2

See ipython/ipython#7079

The code always import the dummy_thread module even on platforms where the real thread module is available. This caused bugs in other packages that use this import style:

try:
    from _thread import interrupt_main  # Py 3
except ImportError:
    from thread import interrupt_main  # Py 2

See  ipython/ipython#7079
edschofield added a commit that referenced this pull request Dec 14, 2014
Fix bug where dummy_thread was always imported
@edschofield
edschofield merged commit aac65c1 into PythonCharmers:master Dec 14, 2014
@edschofield

Copy link
Copy Markdown
Contributor

Morten, thanks very much for your effort with creating this PR!

@edschofield

Copy link
Copy Markdown
Contributor

This has now gone into v0.14.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants